Skip to content

Replace deprecated babel-preset-es2015 #6770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 24, 2020
Merged

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Mar 18, 2020

Partially adresses #6730

babel-preset-es2015 is deprecated, replaced by @babel/preset-env

WARN deprecated babel-preset-es2015@6.24.1: 🙌  Thanks for using Babel: we recommend using babel-preset-env now: please read babeljs.io/env to update!

Followed instructions at https://babeljs.io/docs/en/env/ for upgrade - babel-preset-env was moved to main @babel/preset-env

Unverified

This user has not yet uploaded their public signing key.
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 18, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@chrisbreiding
Copy link
Contributor

I wonder if we can just remove this babel dep entirely. @bahmutov, does the cli even use babel? I can't really see that it does...

@chrisbreiding chrisbreiding removed their request for review April 21, 2020 18:16
@jennifer-shehane
Copy link
Member Author

@bahmutov
Copy link
Contributor

We need to transpile the CLI code, otherwise, we could be using some JS construct accidentally that Node v8.0.0 does not support. We could probably replace babel-cli with an alternative, but I feel we still need to transpile.

3 similar comments
@bahmutov
Copy link
Contributor

We need to transpile the CLI code, otherwise, we could be using some JS construct accidentally that Node v8.0.0 does not support. We could probably replace babel-cli with an alternative, but I feel we still need to transpile.

@bahmutov
Copy link
Contributor

We need to transpile the CLI code, otherwise, we could be using some JS construct accidentally that Node v8.0.0 does not support. We could probably replace babel-cli with an alternative, but I feel we still need to transpile.

@bahmutov
Copy link
Contributor

We need to transpile the CLI code, otherwise, we could be using some JS construct accidentally that Node v8.0.0 does not support. We could probably replace babel-cli with an alternative, but I feel we still need to transpile.

@cypress
Copy link

cypress bot commented Apr 23, 2020



Test summary

7186 0 98 0


Run details

Project cypress
Status Passed
Commit 77e3617
Started Apr 23, 2020 3:21 PM
Ended Apr 23, 2020 3:27 PM
Duration 06:25 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding self-requested a review April 23, 2020 15:15
@jennifer-shehane jennifer-shehane merged commit 79379a9 into develop Apr 24, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 28, 2020

Released in 4.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 28, 2020
@chrisbreiding chrisbreiding deleted the babel-preset-env-dep branch April 5, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants