Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-dependency causing download to fail in enterprise-environments. #6644

Closed
annitya opened this issue Mar 4, 2020 · 3 comments
Closed

Sub-dependency causing download to fail in enterprise-environments. #6644

annitya opened this issue Mar 4, 2020 · 3 comments

Comments

@annitya
Copy link

annitya commented Mar 4, 2020

Current behavior:

The server-package has a dependency tar-fs which has a dependency bl
which contains a file test/indexOf containing the string arglebargleglopglyf.
Our firewall then gets a hit on this signature which causes the download to fail.

The problem is present in 4.1.0, but absent in 4.0.2.

Desired behavior:

Download goes smoothly because there are no "hacking-signatures" in any sub-dependencies

Test code to reproduce

Can't help you with this one I'm afraid. Our firewall is apparently super-secret, so I don't know which tool they are using.

Versions

Cypress, Windows 10 version 4.1.0.

Related

Posted issue in offending dependency here.
Pull-request for said issue.

@jennifer-shehane
Copy link
Member

Opened PR to pull in bl dep update with PR into tar-stream which would then need to be released and updated in tar-fs. mafintosh/tar-stream#113

@cypress-bot cypress-bot bot added the stage: awaiting external fix A 3rd party bug in Cypress - awaiting release label Mar 5, 2020
@annitya
Copy link
Author

annitya commented Mar 5, 2020

Semver should take care of things @jennifer-shehane I installed registry-js locally and it correctly pulled in tar-stream@2.1.1 :)

@jennifer-shehane
Copy link
Member

Closing as resolved.

@jennifer-shehane jennifer-shehane removed the stage: awaiting external fix A 3rd party bug in Cypress - awaiting release label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants