-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update browser icons to use branded iconography #6188
Comments
My concern with this is that we would have to ship Cypress with all the logo images included, which could increase its size a decent bit. Maybe we should decide on a subset of browsers to include, so the size increase is limited? Thoughts, @cypress-io/test-runner? @jennifer-shehane, @brian-mann, where did we land on what to do for the Electron logo? Actual Electron logo, chromium logo, globe icon? |
Yea, that's a fair concern. Even just grabbing the SVGs of the 6 browsers outlined above would suffice for the most common cases. That should add well under 100kb to the overall package size. |
The code for this is done in cypress-io/cypress#6230, but has yet to be released. |
Released in |
Current behavior:
The Test Runner uses the Chrome font-awesome icon for many browser logos, and the Firefox logo is out-of-date with Mozilla's current branding. With cross browser support nearly complete, we should take the opportunity to use official, branded iconography for all of the browsers we support.
Desired behavior:
brave
), attempt to find the correct icon in thebrowser-logos
package. If no icon matches, continue to use the.fa-globe
icon.The text was updated successfully, but these errors were encountered: