Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser icons to use branded iconography #6188

Closed
9 tasks
trydionel opened this issue Jan 17, 2020 · 4 comments · Fixed by #6230
Closed
9 tasks

Update browser icons to use branded iconography #6188

trydionel opened this issue Jan 17, 2020 · 4 comments · Fixed by #6230
Assignees
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory topic: cross browser type: user experience Improvements needed for UX

Comments

@trydionel
Copy link

Current behavior:

The Test Runner uses the Chrome font-awesome icon for many browser logos, and the Firefox logo is out-of-date with Mozilla's current branding. With cross browser support nearly complete, we should take the opportunity to use official, branded iconography for all of the browsers we support.

Screen Shot 2020-01-17 at 1 01 15 PM

Desired behavior:

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jan 21, 2020
@jennifer-shehane jennifer-shehane added type: user experience Improvements needed for UX pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory and removed stage: ready for work The issue is reproducible and in scope labels Jan 21, 2020
@jennifer-shehane jennifer-shehane self-assigned this Jan 21, 2020
@jennifer-shehane jennifer-shehane added the stage: ready for work The issue is reproducible and in scope label Jan 21, 2020
@chrisbreiding
Copy link
Contributor

The test runner allows users to test against arbitrary Chromium browsers. If given a name (e.g. brave), attempt to find the correct icon in the browser-logos package. If no icon matches, continue to use the .fa-globe icon.

My concern with this is that we would have to ship Cypress with all the logo images included, which could increase its size a decent bit. Maybe we should decide on a subset of browsers to include, so the size increase is limited? Thoughts, @cypress-io/test-runner?

@jennifer-shehane, @brian-mann, where did we land on what to do for the Electron logo? Actual Electron logo, chromium logo, globe icon?

@trydionel
Copy link
Author

Yea, that's a fair concern. Even just grabbing the SVGs of the 6 browsers outlined above would suffice for the most common cases. That should add well under 100kb to the overall package size.

@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jan 23, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 27, 2020

The code for this is done in cypress-io/cypress#6230, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jan 27, 2020
@flotwig
Copy link
Contributor

flotwig commented Feb 6, 2020

Released in 4.0.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory topic: cross browser type: user experience Improvements needed for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants