should() chaining

[sainthkh]

• Closes Can't chain mutliple cy.should(callbackFn) #4981

User facing changelog

Now, should() and and() with function argument can be chained.

Additional details

Why was this change necessary?

Sometimes, we want to organize our assertions by chaining should()s but we couldn't.

What is affected by this change?

N/A

Any implementation details to explain?

N/A

How has the user experience changed?

Now code like below works.

cy.wrap('ab')
.should((subject) => {
  expect(subject).to.be.a('string')
  expect(subject).to.contain('a')
})
.should((subject) => {
  expect(subject).to.contain('b')
  expect(subject).to.have.length(2)
})
.and((subject) => {
  expect(subject).to.eq('ab')
  expect(subject).not.to.contain('c')
})

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• [NA] Has a PR for user-facing changes been opened in cypress-documentation?
• [NA] Have API changes been updated in the type definitions?
• [NA] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[jennifer-shehane]

I've manually confirmed that this fixes the 2 failing cases in the original issue.

[chrisbreiding]

Looks good 👍