Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dep @types/blob-util (it's deprecated) #6001

Closed
jennifer-shehane opened this issue Dec 19, 2019 · 3 comments · Fixed by #7795
Closed

Replace dep @types/blob-util (it's deprecated) #6001

jennifer-shehane opened this issue Dec 19, 2019 · 3 comments · Fixed by #7795
Labels
good first issue Good for newcomers process: dependencies Related to internal dependencies topic: typescript type: breaking change Requires a new major release version type: chore Work is required w/ no deliverable to end user

Comments

@jennifer-shehane
Copy link
Member

Current behavior:

We include @types/blob-util as a dep in the cli here: https://github.com/cypress-io/cypress/blob/v4.0-release/cli/package.json#L64:L64

As mentioned in this PR #5684 (review), this dep has been deprecated since blob-util provides it's own types in their package as mentioned here: https://www.npmjs.com/package/%40types/blob-util

Desired behavior:

Replace use of @types/blob-util to include the types correctly.

Versions

3.8.0

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Dec 19, 2019
@jennifer-shehane jennifer-shehane added topic: typescript stage: ready for work The issue is reproducible and in scope good first issue Good for newcomers type: chore Work is required w/ no deliverable to end user process: dependencies Related to internal dependencies and removed stage: ready for work The issue is reproducible and in scope labels Dec 19, 2019
@sainthkh
Copy link
Contributor

After some research, I learned that updating blob-util is a breaking change.

In 1.3.3, the return type of blob-util functions are Promise. But from 2.0.0, they're Blob object. That's why attempting to fix them in #5780 failed.

1.3.0 of blob-util doesn't use TypeScript and @types/blob-util@1.3.3 is not deprecated.

For now, we should use @types/blob-util@1.3.3 and update it to 2.0.2 and remove @types/blob-util at Cypress 4.0.

@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Jan 16, 2020
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jun 23, 2020
@cypress-bot cypress-bot bot added stage: work in progress stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress stage: ready for work The issue is reproducible and in scope labels Jun 24, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Jul 2, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2020

The code for this is done in cypress-io/cypress#7795, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 7, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers process: dependencies Related to internal dependencies topic: typescript type: breaking change Requires a new major release version type: chore Work is required w/ no deliverable to end user
Projects
None yet
2 participants