-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix coords when specified x,y during click #5635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const viewportTargetCoords = getTopLeftCoordinates(fromElViewport) | ||
const windowTargetCoords = getTopLeftCoordinates(fromElWindow) | ||
const AUTwindowTargetCoords = getTopLeftCoordinates(fromAutWindow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this variable should really be named autWindowTargetCoords
and not be capitalized, but ill approve anyway and fix it in develop
there was an edge case in
coordinates.js
that did not attach x,y property tofromAUTWindow
as of3.5.0
we now attach x,y to fromAUTWindow when given offset coords
Closes click red target is at the wrong position in 3.5.0 #5624
User facing changelog
cy.click()
click red target is at the wrong position in 3.5.0 #5624Additional details
How has the user experience changed?
during
cy.click(x, y)
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?