Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Chrome DevTools Protocol to set cookies in Chrome #5206

Closed
flotwig opened this issue Sep 25, 2019 · 3 comments · Fixed by #5297
Closed

Use Chrome DevTools Protocol to set cookies in Chrome #5206

flotwig opened this issue Sep 25, 2019 · 3 comments · Fixed by #5297
Assignees
@flotwig
Labels
topic: cookies 🍪

Comments

@flotwig
Copy link
Contributor

flotwig commented Sep 25, 2019 •
edited

Now that #4720 is merged, Cypress is controlling Electron's cookies API using CDP.

Once Now that #4628 is merged, Cypress will have has access to Chrome's CDP as well.

We should unify the Electron/Chrome cookies code when that happens to cut down on issues that only occur in one or the other and simplify the code somewhat.
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Sep 25, 2019
@flotwig flotwig self-assigned this Oct 2, 2019
@flotwig flotwig mentioned this issue Oct 4, 2019
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Oct 4, 2019
@flotwig flotwig mentioned this issue Oct 11, 2019
Closed
4 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Oct 21, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 21, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 21, 2019

The code for this is done in cypress-io/cypress#5297, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

1 similar comment
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 21, 2019

The code for this is done in cypress-io/cypress#5297, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Nov 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flotwig flotwig

Labels
topic: cookies 🍪
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Control Chrome cookies through CDP cypress-io/cypress
1 participant
@flotwig