Assertion keeps spinning after passing

[bahmutov]

Quite an esoteric test case, but shows some edge case in assertion state management

Cypress 3.1.4 on Mac

Source code in https://github.com/bahmutov/retry-task-demo just clone, install and run

I am retrying a function that calls either a simple async promise-returning function or a function that calls cy.task. In both cases little utility function retry checks the upcoming assertion to stop.

const getRandomNumber = () => {
  return new Cypress.Promise((resolve, reject) => {
    setTimeout(() => {
      const x = Cypress._.random(0, 50)
      console.log('resolving with %d', x)
      resolve(x)
    }, 10)
  })
}

const retry = fn => () => {
  return fn().then(value => {
    return cy.verifyUpcomingAssertions(
      value,
      {},
      {
        onRetry: retry(fn)
      }
    )
  })
}

it('retries task', () => {
  let counter = 0
  const limit = 100
  const printToTerminal = () => cy.task('print', (counter += 1), { log: false })

  // cypress-pipe does not retry Cypress chains
  // cy.document()
  //   // .pipe(printToTerminal)
  //   .should('equal', limit)

  cy.log('retrying task')
  cy.then(retry(printToTerminal)).should('equal', limit)

  cy.log('retrying async random number')
  cy.then({ timeout: 10000 }, retry(getRandomNumber)).should('equal', 10)
})

The getRandomNumber retries itself fine and stops, and the assertion is green.

The printToTerminal that calls cy.task runs, retries, passes - but the assertion is still spinning in the UI

[Saibamen]

Confirmed in Cypress 3.1.4 running on Win 10 both Chrome 71 and Electron 59

[jennifer-shehane]

Closing as duplicate of #2380