fix: test:after:run
passes the runnable
#25678
Merged
+229
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The
runnable
parameter was inadvertently removed with facfd0d. Added the parameter back by refactoring to not modify the Cypresstest:after:run
event and instead pass along theisInteractive
parameter to the reporter from the runner.Also noticed the
log:added
andlog:changed
events were incorrectly typed stating they were passing theinteractive
boolean as the second parameter when in actuality thelog
was the second parameter and theinteractive
parameter is not being passed.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?