Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test:after:run passes the runnable #25678

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Feb 2, 2023

Additional details

The runnable parameter was inadvertently removed with facfd0d. Added the parameter back by refactoring to not modify the Cypress test:after:run event and instead pass along the isInteractive parameter to the reporter from the runner.

Also noticed the log:added and log:changed events were incorrectly typed stating they were passing the interactive boolean as the second parameter when in actuality the log was the second parameter and the interactive parameter is not being passed.

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile
@cypress
Copy link

cypress bot commented Feb 2, 2023

Passing run #43723 ↗︎

0 565 0 0 Flakiness 0

Details:

remove listener
Project: cypress Commit: 27cc4a1258
Status: Passed Duration: 07:17 💡
Started: Feb 2, 2023 1:52 PM Ended: Feb 2, 2023 1:59 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile

Verified

This commit was signed with the committer’s verified signature.
mschile Matt Schile
@emilyrohrbough emilyrohrbough merged commit beb411f into develop Feb 2, 2023
@emilyrohrbough emilyrohrbough deleted the mschile/issue-25663 branch February 2, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runnable instance not passed to test:after:run
3 participants