Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update types #25538

Merged
merged 2 commits into from
Jan 24, 2023
Merged

chore: update types #25538

merged 2 commits into from
Jan 24, 2023

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Jan 23, 2023

User facing changelog

n/a

Additional details

Update types.

Steps to test

  • Clone https://github.com/lmiller1990/cypress-issue-23653
  • yarn && yarn vue-tsc --noEmit
  • error!
  • grab this branch for Cypress
  • cd npm/vue && yarn build
  • cp ../../cli/vue/dist/* ~/code/dump/cypress-issue-23653/node_modules/cypress/vue/dist/
  • now it can compile: yarn vue-tsc --noEmit

How has the user experience changed?

No error when running vue-tsc.

PR Tasks

  • [na] Have tests been added/updated? Not sure how to really test this, we need to be on vue@latest to reproduce.
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@@ -92,6 +92,7 @@ const cleanup = () => {
* `MountOptions` are modifying, including some Cypress specific options like `styles`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed the instructions above here (line 85-94) to fix it. Just copy paste the latest types.

@lmiller1990 lmiller1990 marked this pull request as ready for review January 23, 2023 00:51
@cypress
Copy link

cypress bot commented Jan 23, 2023



Test summary

4278 0 881 0Flakiness 7


Run details

Project cypress
Status Passed
Commit 7e2f18c
Started Jan 23, 2023 11:03 PM
Ended Jan 23, 2023 11:19 PM
Duration 15:39 💡
OS Linux Debian -
Browser WebKit 16

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
2 ... > with `times` > only uses each handler N times
3 network stubbing > waiting and aliasing > can timeout waiting on a single response using "alias"
4 ... > stops waiting when an xhr request is canceled
cypress/cypress.cy.js Flakiness
1 ... > correctly returns currentRetry
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 requested a review from a team January 23, 2023 05:51
Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me 👍🏻

@lmiller1990 lmiller1990 requested a review from a team January 23, 2023 23:21
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the example project and works great 👍

@lmiller1990 lmiller1990 merged commit bba226c into develop Jan 24, 2023
@lmiller1990 lmiller1990 deleted the issue-24818 branch January 24, 2023 01:56
tgriesser added a commit that referenced this pull request Jan 26, 2023
* develop: (27 commits)
  refactor: remove unused cloud routes (#25584)
  chore: fix issue template formatting issue (#25587)
  fix: fixed issue with CT + electron + run mode not exiting properly (#25585)
  chore(deps): update dependency ua-parser-js to v0.7.33 [security] (#25561)
  fix: add alternative binary names for edge-beta (#25456)
  chore: add batch execution to CloudDataSource (#22457)
  chore: End a/b campaigns for aci smart banners (#25504)
  chore: release @cypress/schematic-v2.5.0
  fix(cypress-schematic): do not disable e2e support file (#25400)
  chore: adding memory issue template (#25559)
  feat: Add Angular CT Schematic (#24374)
  chore: enforce changelog entries on PR reviews (#25459)
  chore: bump package.json to 12.4.0 [run ci] (#25556)
  feat: Add 'type' option to `.as` to store aliases by value (#25251)
  chore: release @cypress/webpack-dev-server-v3.2.3
  feat: Display line break in cy.log (#25467)
  chore: update types (#25538)
  fix: Revert "fix: adding emergency garbage collection for chromium-based browsers" (#25546)
  fix: percy - wait to take snapshot until previous tooltips are gone (#25522)
  feat: support data-qa selector in selector playground (#25475)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue mount type definitions error on SFCs with only one define API used
3 participants