fix: percy - wait to take snapshot until previous tooltips are gone #25522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-io/cypress into astone123/fix-config-percy-flake# Please enter a commit message to explain why this merge is necessary,
ZachJW34
approved these changes
Jan 19, 2023
| cy.percySnapshot() | ||
| cy.get('.v-popper__popper--shown').should('have.length', 1).then(() => { | ||
| // Take a snapshot after the other tooltips have closed | ||
| cy.percySnapshot() |
There was a problem hiding this comment.
Nit: Could add this inside the each after the realHover
There was a problem hiding this comment.
I don't think we need to take a snapshot for each tooltip, just one. What do you think?
There was a problem hiding this comment.
Ah snap I meant to comment on the cy.get('.v-popper__popper--shown').should('have.length', 1), if you bumped that up it would enforce each interaction to deal with only one tooltip, then you wouldn't have to add it below.
There was a problem hiding this comment.
ah right, good call
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
tgriesser
added a commit
that referenced
this pull request
Jan 26, 2023
* develop: (27 commits) refactor: remove unused cloud routes (#25584) chore: fix issue template formatting issue (#25587) fix: fixed issue with CT + electron + run mode not exiting properly (#25585) chore(deps): update dependency ua-parser-js to v0.7.33 [security] (#25561) fix: add alternative binary names for edge-beta (#25456) chore: add batch execution to CloudDataSource (#22457) chore: End a/b campaigns for aci smart banners (#25504) chore: release @cypress/schematic-v2.5.0 fix(cypress-schematic): do not disable e2e support file (#25400) chore: adding memory issue template (#25559) feat: Add Angular CT Schematic (#24374) chore: enforce changelog entries on PR reviews (#25459) chore: bump package.json to 12.4.0 [run ci] (#25556) feat: Add 'type' option to `.as` to store aliases by value (#25251) chore: release @cypress/webpack-dev-server-v3.2.3 feat: Display line break in cy.log (#25467) chore: update types (#25538) fix: Revert "fix: adding emergency garbage collection for chromium-based browsers" (#25546) fix: percy - wait to take snapshot until previous tooltips are gone (#25522) feat: support data-qa selector in selector playground (#25475) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
In
ConfigCode.cy.tsx, we're taking a snapshot with Percy that flakes sometimes because the snapshot sometimes happens before the previous hovered tooltip has faded of screen. I added an assertion to wait until there's only one tooltip on screen before taking the snapshot. This should make the snapshot more stable.Steps to test
Check out the Percy snapshot result from CI. We should see it fail on this branch, but once it's built in develop, it shouldn't flake anymore. I noticed this on the build on Mike's PR where it flaked.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?