fix: make NODE_ENV "production" for prod builds of launchpad #25320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
approved these changes
Jan 3, 2023
BlueWinds
approved these changes
Jan 3, 2023
ZachJW34
approved these changes
Jan 3, 2023
tgriesser
added a commit
that referenced
this pull request
Jan 18, 2023
* develop: (45 commits) fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364) fix: add skip domain injection description (#25463) fix: revert CSP header and script-src addition (#25445) chore: Update v8 snapshot cache (#25401) feat: Do not strip CSP headers from HTTPResponse (#24760) fix: keep spaces in formatted output in test runner (#24687) fix: Restrict dependency versions to known supported ranges (#25380) chore: Update v8 snapshot cache (#25370) feat: experimental skip domain injection (#25307) chore: support vite v4 for component testing (#25365) feat: Use JSX/TSX in generated spec filenames (#25318) docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359) chore: remove lint-changed from scripts/docs (#25308) chore: bump to 12.3.0 [skip ci] (#25355) fix: make NODE_ENV "production" for prod builds of launchpad (#25320) fix: .contains() should only return one element at all times (#25250) feat: add currentRetry to Cypress API (#25297) chore: release @cypress/webpack-dev-server-v3.2.2 chore: release create-cypress-tests-v2.0.1 fix: change wording for spec creation (#25271) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue has been created for this, it's just something I noticed when somebody shared a screenshot on Discord.
User facing changelog
Error toasts will no longer incorrectly display in the launchpad.
Additional details
Couple of small changes to make sure that, which not watching app and launchpad builds, but doing a regular production build, we pass the
process.env.NODE_ENVthrough for use in Vue. This corrects an issue where it is currently possible to see low quality error toasts that are intended for use during development, in the production launchpad.I also removed
productionfrom the app watch job since in situations where we are in watch mode, that's development and we want the toasts to appear.There are no other side-effects of this change that I can think of, as nothing else in the Vue app is looking at
process.env.NODE_ENV.Steps to test
Not many great ways to test this, I did build a binary locally to make sure that the settings I changed were definitely used and printed out the
NODE_ENVin the UI:How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?