Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add currentRetry to Cypress API #25297

Merged

Conversation

Pashozator
Copy link
Contributor

@Pashozator Pashozator commented Dec 28, 2022

User facing changelog

Add current retry to Cypress API.

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 28, 2022

Thanks for taking the time to open a PR!

@Pashozator Pashozator force-pushed the issue-25239-expose-current-retry branch 2 times, most recently from a477214 to 6bc0543 Compare December 28, 2022 20:26
@emilyrohrbough emilyrohrbough changed the title feat: add currentRetry to Cypress feat: add currentRetry to Cypress API Dec 29, 2022
@Pashozator Pashozator marked this pull request as ready for review December 29, 2022 17:54
@Pashozator Pashozator force-pushed the issue-25239-expose-current-retry branch from 1be425b to 6d2be39 Compare December 29, 2022 17:54
@cypress
Copy link

cypress bot commented Dec 29, 2022



Test summary

26394 0 1179 0Flakiness 29


Run details

Project cypress
Status Passed
Commit 6d2be39
Started Dec 29, 2022 6:08 PM
Ended Dec 29, 2022 6:27 PM
Duration 19:39 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

create-from-component.cy.ts Flakiness
1 ... > runs generated spec
e2e/origin/cookie_login.cy.ts Flakiness
1 ... > past Max-Age, before Expires -> not logged in
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
2 network stubbing > intercepting request > can delay and throttle a StaticResponse
3 network stubbing > intercepting request > can delay and throttle a StaticResponse
This comment includes only the first 5 flaky tests. See all 29 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@Pashozator Pashozator force-pushed the issue-25239-expose-current-retry branch from 6d2be39 to 15535d4 Compare December 30, 2022 08:33
@BlueWinds
Copy link
Contributor

We'll also need to add this to the docs.

@emilyrohrbough emilyrohrbough merged commit acc61d8 into cypress-io:develop Jan 3, 2023
@Pashozator Pashozator deleted the issue-25239-expose-current-retry branch January 3, 2023 19:03
tgriesser added a commit that referenced this pull request Jan 18, 2023
* develop: (45 commits)
  fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364)
  fix: add skip domain injection description (#25463)
  fix: revert CSP header and script-src addition (#25445)
  chore: Update v8 snapshot cache (#25401)
  feat: Do not strip CSP headers from HTTPResponse (#24760)
  fix: keep spaces in formatted output in test runner (#24687)
  fix: Restrict dependency versions to known supported ranges (#25380)
  chore: Update v8 snapshot cache (#25370)
  feat: experimental skip domain injection (#25307)
  chore: support vite v4 for component testing (#25365)
  feat: Use JSX/TSX in generated spec filenames (#25318)
  docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359)
  chore: remove lint-changed from scripts/docs (#25308)
  chore: bump to 12.3.0 [skip ci] (#25355)
  fix: make NODE_ENV "production" for prod builds of launchpad (#25320)
  fix: .contains() should only return one element at all times (#25250)
  feat: add currentRetry to Cypress API (#25297)
  chore: release @cypress/webpack-dev-server-v3.2.2
  chore: release create-cypress-tests-v2.0.1
  fix: change wording for spec creation (#25271)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants