Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change wording for spec creation #25271

Merged
merged 11 commits into from Jan 3, 2023
Merged

fix: change wording for spec creation #25271

merged 11 commits into from Jan 3, 2023

Conversation

Manuel-Suarez-Abascal
Copy link
Contributor

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal commented Dec 26, 2022 •
edited by lmiller1990

User-facing changelog

Fix misleading wording when creating a new starter spec file in the UI.

Additional details

N/A

Steps to test

  • Launch Cypress's test runner.
  • Click on the button New Spec button.
  • You should see the new wording in the cards to create a new starter spec file.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 26, 2022

Thanks for taking the time to open a PR!

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal mentioned this pull request Dec 26, 2022
Closed
4 tasks
@cypress
Copy link

cypress bot commented Dec 26, 2022 •
edited


Test summary

454 • 3 • 5 • 0 • Flakiness 5

Run details
Project cypress
Status Failed
Commit fd2019d
Started Dec 30, 2022 4:04 PM
Ended Dec 30, 2022 4:17 PM
Duration 12:37 💡
OS Linux Debian -
Browser Chrome 106

View run in Cypress Dashboard ➡️

Failures

cypress/e2e/specs.cy.ts 3 Failed
1 ... > shows extension warning
2 ... > scaffold empty spec > should generate empty spec
3 ... > scaffold empty spec > generates spec with file name that does not contain a known spec extension

Flakiness

create-from-component.cy.ts 1 Flakiness
1 ... > runs generated spec
specs_list_latest_runs.cy.ts 1 Flakiness
1 App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs
cypress-in-cypress-run-mode.cy.ts 2 Flakiness
1 Cypress In Cypress - run mode > e2e run mode spec runner header is correct
2 Cypress In Cypress - run mode > component testing run mode spec runner header is correct
cypress-origin-communicator.cy.ts 1 Flakiness
1 Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor

lmiller1990 commented Dec 26, 2022 •
edited

Did you apply the requested changes from #24825 @Manuel-Suarez-Abascal?

Thanks, I triggered a CI run for you.

@Manuel-Suarez-Abascal
Copy link
Contributor Author

Did you apply the requested changes from #24825 @Manuel-Suarez-Abascal?

Thanks, I triggered a CI run for you.

👋🏻
I have replied to Emily here. Waiting for confirmation on her end.

@emilyrohrbough
Copy link
Member

emilyrohrbough commented Dec 27, 2022 •
edited

@Manuel-Suarez-Abascal Thanks for linking to your comment. I likely wouldn't have looked at the closed review. Glad you were able to get the CLA issue figured out!

@Manuel-Suarez-Abascal
Copy link
Contributor Author

@lmiller1990 @emilyrohrbough I have addressed the PR comment. Let me know your thoughts or any other changes that I might have missed.

@emilyrohrbough emilyrohrbough changed the title fix: change wording for spec creation misc: change wording for spec creation Dec 27, 2022
@emilyrohrbough
Copy link
Member

@Manuel-Suarez-Abascal looks like there a few failing tests with these changes.

@lmiller1990
Copy link
Contributor

lmiller1990 commented Dec 27, 2022 •
edited

One of the component tests looks to be failing. Take a quick look @Manuel-Suarez-Abascal?

Thanks! Just do cd packages/app && yarn cypress:run:ct --chrome locally if you need to verify they all pass before pushing, they are pretty quick. Throw in --headed to watch them.

@Manuel-Suarez-Abascal
Copy link
Contributor Author

One of the component tests looks to be failing. Take a quick look @Manuel-Suarez-Abascal?

Thanks! Just do cd packages/app && yarn cypress:run:ct --chrome locally if you need to verify they all pass before pushing, they are pretty quick. Throw in --headed to watch them.

Thanks, @lmiller1990 I have to try to fix the error, but I'm not exactly sure why it's failing. I will need more time debugging it, but it doesn't find the Create new spec text on the screen which as you see in the screenshot below it's present. Thoughts 💭 ?

Screenshot 2022-12-29 at 8 05 08 AM

@emilyrohrbough emilyrohrbough changed the title misc: change wording for spec creation fix: change wording for spec creation Dec 30, 2022
@Manuel-Suarez-Abascal
Copy link
Contributor Author

@emilyrohrbough @lmiller1990 I have addressed the PR comments & fixed the failing spec files. I think it's ready for another review :)

Screenshot 2022-12-30 at 11 01 34 AM

@emilyrohrbough emilyrohrbough merged commit c12a7e3 into cypress-io:develop Jan 3, 2023
tgriesser added a commit that referenced this pull request Jan 18, 2023
@tgriesser
Merge branch 'develop' into tgriesser/spike/spike
3e305cd 
* develop: (45 commits)
  fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364)
  fix: add skip domain injection description (#25463)
  fix: revert CSP header and script-src addition (#25445)
  chore: Update v8 snapshot cache (#25401)
  feat: Do not strip CSP headers from HTTPResponse (#24760)
  fix: keep spaces in formatted output in test runner (#24687)
  fix: Restrict dependency versions to known supported ranges (#25380)
  chore: Update v8 snapshot cache (#25370)
  feat: experimental skip domain injection (#25307)
  chore: support vite v4 for component testing (#25365)
  feat: Use JSX/TSX in generated spec filenames (#25318)
  docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359)
  chore: remove lint-changed from scripts/docs (#25308)
  chore: bump to 12.3.0 [skip ci] (#25355)
  fix: make NODE_ENV "production" for prod builds of launchpad (#25320)
  fix: .contains() should only return one element at all times (#25250)
  feat: add currentRetry to Cypress API (#25297)
  chore: release @cypress/webpack-dev-server-v3.2.2
  chore: release create-cypress-tests-v2.0.1
  fix: change wording for spec creation (#25271)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 'create new empty spec' messaging.
3 participants
@Manuel-Suarez-Abascal @lmiller1990 @emilyrohrbough