Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: truncate text to fix layout #25270

Merged
merged 10 commits into from Dec 29, 2022
Merged

fix: truncate text to fix layout #25270

merged 10 commits into from Dec 29, 2022

Conversation

Manuel-Suarez-Abascal
Copy link
Contributor

User-facing changelog

It truncates the browser name in the UI in order to avoid layout issues when the browser name is too long.

Additional details

N/A

Steps to test

  • Install Firefox Developer Edition browser.
  • Launch Cypress.

How has the user experience changed?

An ellipsis will be added if the browser name is too long. Ellipsis will be added if the browser name is more than 16 characters.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 26, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 26, 2022



Test summary

26393 0 1179 0Flakiness 32


Run details

Project cypress
Status Passed
Commit 279b344
Started Dec 29, 2022 9:02 PM
Ended Dec 29, 2022 9:20 PM
Duration 18:56 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

create-from-component.cy.ts Flakiness
1 ... > runs generated spec
2 ... > runs generated spec
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
2 network stubbing > intercepting request > can delay and throttle a StaticResponse
3 network stubbing > intercepting request > can delay and throttle a StaticResponse
This comment includes only the first 5 flaky tests. See all 32 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@emilyrohrbough
Copy link
Member

@elevatebart @marktnoonan Could you re-review this PR from @Manuel-Suarez-Abascal ? You both initially provided feedback on #24831 which was closed and replaced with this PR to fix the CLA issue.

Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Manuel-Suarez-Abascal & thank you for addressing the CLA issue, I think we actually need one other small CSS change to the same line to correct a spacing issue, then we can approve and merge. I'm made a comment with a padding change that works.

packages/launchpad/src/setup/OpenBrowserList.vue Outdated Show resolved Hide resolved
Co-authored-by: Stokes Player <stokes.player@gmail.com>
@marktnoonan marktnoonan merged commit 3925ae0 into cypress-io:develop Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser icons and longer names in the dropdown menu don't display correctly
5 participants