New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit the number of globals defined due to the v8 snapshot #25051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
ryanthemanuel
commented
Dec 8, 2022
@@ -109,101 +109,110 @@ export function scriptFromBlueprint (config: BlueprintConfig): { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mjhenkes
approved these changes
Dec 8, 2022
AtofStryker
approved these changes
Dec 8, 2022
mschile
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Limit the number of globals defined in memory due to the v8 snapshot
Additional details
We inadvertently created a bunch of globals when setting things up in the v8 snapshot. Specifically:
In the spirit of only exposing what is necessary, we are going to ensure that we are only exposing
getSnapshotResult
andsupportTypeScript
. We do this by wrapping the entire snapshot creation inside of an IIFE.Steps to test
Ultimately, this can be tested by validate that the tests are passing on the PR and that the new smoke test is passing.
How has the user experience changed?
n/a
PR Tasks
cypress-documentation
?type definitions
?