fix: .contains() selects proper elements when inside a <form>

[BlueWinds]

• Closes Cypress 12.0.1 - contains(element,text) inside within fails #25019

User facing changelog

In 12.0.0, we had a regression around .contains() where if the subject was a <form> element, it would only consider the first <input> element in the form, rather than every child. This PR fixes the regression.

Additional details

In addition to the added driver test, this test demonstrates the issue "in the wild":

    it('Should be able to target elements within a form', () => {
        cy.visit('https://www.demoblaze.com/');
        cy.contains('a', 'Log in').click();

        cy.get('#logInModal').within(() => {
            cy.get('form').within(() => {
                // these work
                cy.contains('Username:').should('be.visible');
                cy.contains('Username').parent().should('be.visible');
                cy.get('input').first().should('be.visible');

                // this doesn't
                cy.contains('label', 'Username')
            })
        })
    });

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
• [n/a] Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[BlueWinds]

I tested this in conjunction with #25035 before pulling it into its own branch / PR, so they definitely work cleanly together.

[cypress]

---

Test summary

24860 • 0 • 2489 • 0 • 23

---

Run details

Project	cypress
Status	Passed
Commit	a7bb162
Started	Dec 7, 2022 9:55 PM
Ended	Dec 7, 2022 10:13 PM
Duration	17:57 💡
OS	Linux Debian -
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/e2e/e2e/origin/cookie_behavior.cy.ts		5
1	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2	... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4	... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5	... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 23 flaky tests in the Cypress Dashboard.

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[emilyrohrbough]

are there issues with scoping form inputs to the withinsubject and then running commands within that?

[BlueWinds]

are there issues with scoping form inputs to the withinsubject and then running commands within that?

Scoping .contains() to a <form> with .within() hits the exact same logic - and runs into the exact same issue - as having a <form> as the subject.

I tend not to like writing multiple tests where there are multiple ways a user could encounter the same regression.