Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: windows app integration tests scaffolding issues #25032

Merged
merged 1 commit into from Dec 7, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 7, 2022

  • Closes n/a

User facing changelog

n/a

Additional details

Some of our windows app integration tests were failing to scaffold the project with permission errors.

> EPERM: operation not permitted, stat 'C:\Users\circleci\AppData\Local\Temp\cy-projects\session-and-origin-e2e-specs'

Changing the async copy to a sync copy seems to fix the issue.

Steps to test

Verify the runner/cypress sessions.ui.spec test no longer fails in windows.

How has the user experience changed?

n/a

PR Tasks

  • [n/a] Have tests been added/updated?
  • [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 7, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 7, 2022



Test summary

24850 0 2489 0Flakiness 24


Run details

Project cypress
Status Passed
Commit 5bb94f1
Started Dec 7, 2022 4:41 PM
Ended Dec 7, 2022 4:59 PM
Duration 17:41 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 24 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why moving to the sync method fixes it... but hey, if it works it works.

@mschile mschile merged commit 7565282 into develop Dec 7, 2022
@mschile mschile deleted the mschile/windows_session branch December 7, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants