Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update session api types & exposed global helpers #24980

Merged
merged 9 commits into from Dec 6, 2022

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Dec 5, 2022

User facing changelog

Add types for Cypress.session Cypress APIs we want to expose publically.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 5, 2022

Thanks for taking the time to open a PR!

cli/types/cypress.d.ts Outdated Show resolved Hide resolved
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
emilyrohrbough and others added 2 commits December 5, 2022 15:46
Co-authored-by: Matt Schile <mschile@cypress.io>
Co-authored-by: Matt Schile <mschile@cypress.io>
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
Co-authored-by: Matt Schile <mschile@cypress.io>
@cypress
Copy link

cypress bot commented Dec 5, 2022



Test summary

24849 0 2490 0Flakiness 21


Run details

Project cypress
Status Passed
Commit 8121fb3
Started Dec 6, 2022 1:58 PM
Ended Dec 6, 2022 2:16 PM
Duration 18:00 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 21 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
@@ -16,6 +16,7 @@
"@babel/code-frame": "7.8.3",
"@cypress/sinon-chai": "2.9.1",
"@cypress/unique-selector": "0.4.4",
"@cypress/webpack-dev-server": "0.0.0-development",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this dependency added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting local typesript errors because we use it in our cypress.config.js file: https://github.com/cypress-io/cypress/blob/develop/packages/driver/cypress.config.ts#L2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. Didn't realize the driver had any component tests, though the ones that exist seem sort of unnecessary, especially since the driver doesn't render any components. We should probably remove those and the associated configuration, but that can wait.

@emilyrohrbough emilyrohrbough merged commit 797c8f8 into develop Dec 6, 2022
@emilyrohrbough emilyrohrbough deleted the cypress-session-types branch December 6, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants