New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update session api types & exposed global helpers #24980
Conversation
Thanks for taking the time to open a PR!
|
Co-authored-by: Matt Schile <mschile@cypress.io>
Co-authored-by: Matt Schile <mschile@cypress.io>
Co-authored-by: Matt Schile <mschile@cypress.io>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
@@ -16,6 +16,7 @@ | |||
"@babel/code-frame": "7.8.3", | |||
"@cypress/sinon-chai": "2.9.1", | |||
"@cypress/unique-selector": "0.4.4", | |||
"@cypress/webpack-dev-server": "0.0.0-development", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this dependency added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting local typesript errors because we use it in our cypress.config.js file: https://github.com/cypress-io/cypress/blob/develop/packages/driver/cypress.config.ts#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. Didn't realize the driver had any component tests, though the ones that exist seem sort of unnecessary, especially since the driver doesn't render any components. We should probably remove those and the associated configuration, but that can wait.
User facing changelog
Add types for Cypress.session Cypress APIs we want to expose publically.
cypress-documentation
? Cypress.Session Cypress API cypress-documentation#4900type definitions
?