fix: bring back initial loading spinner in launchpad #24922
Merged
+78
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #24950
User facing changelog
The launchpad will now show a loading spinner on startup to indicate that it has successfully started an is a loading state.
Additional details
We had this previously but some changes to the launchpad in 10.11.0 unintentionally removed it. This PR adds the spinner in the
index.html
to display it as quickly as possible, before JS has even loaded and mounted the app.Steps to test
Open and Cypress project and make sure that you see a spinner before the Testing Type picker.
How has the user experience changed?
Before - no spinner, blank screen until testing type cards appear:
After - spinner immediately on startup
PR Tasks
cypress-documentation
?type definitions
?