Skip to content

fix: bring back initial loading spinner in launchpad #24922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 2, 2022

Conversation

marktnoonan
Copy link
Contributor

@marktnoonan marktnoonan commented Dec 1, 2022

Closes: #24950

User facing changelog

The launchpad will now show a loading spinner on startup to indicate that it has successfully started an is a loading state.

Additional details

We had this previously but some changes to the launchpad in 10.11.0 unintentionally removed it. This PR adds the spinner in the index.html to display it as quickly as possible, before JS has even loaded and mounted the app.

Steps to test

Open and Cypress project and make sure that you see a spinner before the Testing Type picker.

How has the user experience changed?

Before - no spinner, blank screen until testing type cards appear:

Screen Shot 2022-12-01 at 12 19 43 PM

After - spinner immediately on startup

Screen Shot 2022-12-01 at 12 19 26 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 1, 2022

Thanks for taking the time to open a PR!

@marktnoonan marktnoonan changed the title fix casing to be consistent with the previous button state fix: bring back initial loading spinner in launchpad Dec 1, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@marktnoonan marktnoonan marked this pull request as ready for review December 1, 2022 17:21
Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@marktnoonan marktnoonan requested a review from a team December 2, 2022 17:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@marktnoonan marktnoonan merged commit 89f3774 into develop Dec 2, 2022
@marktnoonan marktnoonan deleted the marktnoonan/loading-spinner branch December 2, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launchpad loading spinner on startup
3 participants