Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Vite + associated dependencies #24729

Closed
lmiller1990 opened this issue Nov 18, 2022 · 2 comments
Closed

Update Vite + associated dependencies #24729

lmiller1990 opened this issue Nov 18, 2022 · 2 comments
Labels
CT Issue related to component testing pkg/app This is due to an issue in the packages/app directory pkg/launchpad This is due to an issue in the packages/launchpad directory process: dependencies Related to internal dependencies

Comments

@lmiller1990
Copy link
Contributor

lmiller1990 commented Nov 18, 2022 •
edited

Current behavior

I want to use Vitest in the monorepo for faster unit tests. I'd like to start adding more unit tests around the complex logic in app and launchpad, and since we use Vite there already, Vitest would be a good candidate.

I tried adding it but we have some incompatibilities, we need to update Vite and esbuild before we add Vitest

Desired behavior

Update Vite related dependencies.
@lmiller1990 lmiller1990 added process: dependencies Related to internal dependencies CT Issue related to component testing pkg/app This is due to an issue in the packages/app directory pkg/launchpad This is due to an issue in the packages/launchpad directory labels Nov 18, 2022
@lmiller1990
Copy link
Contributor Author

#25101 did most
Last one is #25140

@lmiller1990
Copy link
Contributor Author

We are on Vite 4 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CT Issue related to component testing pkg/app This is due to an issue in the packages/app directory pkg/launchpad This is due to an issue in the packages/launchpad directory process: dependencies Related to internal dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lmiller1990