New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue with loading typescript and v8 snapshot #24684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for taking the time to open a PR!
|
ryanthemanuel
commented
Nov 15, 2022
emilyrohrbough
approved these changes
Nov 15, 2022
mjhenkes
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A
Additional details
No new functional fixes, but the combination of #24677 and #24675 exposed a timing problem. Specifically typescript is no longer detected in a consumer project.
require.resolve
was fixed on this PR however there was a scenario that was missed to ensure that whenever we are callingrequire.resolve
the original version is called whenpaths
are provided.Steps to test
Use the binary from this PR and try and migrate a project that uses typescript from 9 to 11 and ensure that typescript is properly detected
How has the user experience changed?
n/a
PR Tasks
cypress-documentation
?type definitions
?