fix: junit reporters crashing on failed asserts #24677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
approved these changes
Nov 14, 2022
chrisbreiding
approved these changes
Nov 14, 2022
BlueWinds
reviewed
Nov 14, 2022
| pec -- afterEach hooks -- runs this -- after each hook (failed).png | ||
| - /XXX/XXX/XXX/cypress/screenshots/simple_failing_hook.cy.js/simple failing hook s (1280x720) | ||
| - /XXX/XXX/XXX/cypress/screenshots/simple_failing_hook.cy.js/simple failing hook s (2560x1440) |
There was a problem hiding this comment.
Why would this change increase the snapshot size? This seems quite large for a default snapshot size.
There was a problem hiding this comment.
that's the size of the launched browser
BlueWinds
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress runcrashes when assertion in test fails #24652User facing changelog
Cypress will no longer crash when using the junit reporter on failed asserts
Additional details
It appears that we have a delicate ordering for our logic to override mocha resolution. We need to ensure that it is loaded at the appropriate time or things get loaded incorrectly. I tried moving that loading around to various places in the code base, to no avail. The only thing I could get to work was to ensure that the dependencies in this PR don't defer when they load their dependencies. It's not ideal, but we now have a system test for this scenario that should prevent things like this in the future.
Steps to test
Write a failing test and use the
junitreporterHow has the user experience changed?
cypress runno longer crashes when an assert failsPR Tasks
cypress-documentation?type definitions?