fix: migrating from <10 to current with typescript

[ryanthemanuel]

• Closes Migration in V11 not working have to go over 10 #24643

User facing changelog

Users can migrate from Cypress versions < 10 to 11 without hanging

Additional details

The prettier dependency that we use to format code in the 10 migration is not properly being rewritten during the snapshot doctoring process. I am forcing the portions of that dependency that we rely on to be force norewrite so that this no longer happens.

Steps to test

Migrate a project that uses typescript from 9 -> 11.

How has the user experience changed?

The app no longer hangs when migrating from 9 -> 11

PR Tasks

• [na] Have tests been added/updated?
• [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[emilyrohrbough]

Would a system test have caught this error?

[emilyrohrbough]

how do we know this won't change under the hood with new versions of prettier or if we use new imports from prettier?

[ryanthemanuel]

Unfortunately, we don't have a mechanism to verify this today. cypress in cypress testing does not use snapshots due to how the child cypress server is being launched. This is something I want to investigate a solution to ASAP, but for now I think it's worth getting this fix in.

[emilyrohrbough]

Does this need to be manually verified at release then for each release?

[ryanthemanuel]

I think we would only need to verify it if we update the version of prettier that is being used: https://github.com/cypress-io/cypress/blob/develop/packages/data-context/package.json#L45

[cypress]

---

Test summary

548 • 8 • 42 • 64 • 12

---

Run details

Project	cypress
Status	Failed
Commit	74310d0
Started	Nov 14, 2022 7:09 PM
Ended	Nov 14, 2022 7:24 PM
Duration	15:35 💡
OS	Windows 10.0.17763
Browser	Chrome 107

View run in Cypress Dashboard ➡️

---

Failures

Run group: app-e2e (Windows, Chrome )
	cypress\e2e\runner\sessions.ui.cy.ts		1
1	... > setup has failing Cypress command
	cypress\e2e\cypress-in-cypress.cy.ts		1
1	Cypress in Cypress > handles automation disconnects in component
	cypress\e2e\settings.cy.ts		1
1	App: Settings > visits settings page
	cypress\e2e\runner\reporter-ct-vite.uncaught-errors.cy.ts		1
1	uncaught errors
	cypress\e2e\cypress-origin-communicator.cy.ts		1
1	Cypress In Cypress Origin Communicator > primary origin memory leak prevention > cleans up the primaryOriginCommunicator events when navigating away from the /specs to /runs
	cypress\e2e\reporter_header.cy.ts		1
1	Reporter Header > Specs Shortcut > selects the correct spec in the Specs List
	cypress\e2e\specs_list_flaky.cy.ts		1
1	App: Spec List - Flaky Indicator > shows the "Flaky" badge on specs considered flaky
Run group: launchpad-e2e (Windows, Chrome )
	cypress\e2e\top-nav-launchpad.cy.ts		1
1	... > global mode > shows "continue" button after login if project selected

---

Flakiness

	cypress\e2e\migration.cy.ts		1
1	Full migration flow for each project > completes journey for migration-component-testing
	cypress\e2e\specs.cy.ts		1
1	... > shows create first spec page with scaffold and create empty spec options
	cypress\e2e\scaffold-component-testing.cy.ts		3
1	scaffolding component testing > vuecli4vue2 > scaffolds component testing for Vue CLI 4 w/ Vue 2 project
2	scaffolding component testing > vuecli5vue3 > scaffolds component testing for Vue CLI 5 w/ Vue 3 project
3	scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite
This comment includes only the first 5 flaky tests. See all 12 flaky tests in the Cypress Dashboard.

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[mjhenkes]

I'll approve this in the spirit of getting the fix out however it would be nice to have tests to insure that we don't regress here in the future.