New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make error more inclusive of future cypress versions #24559
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, definitely not intending that people upgrade to 10 separately - 9.x -> 11.0 is expected to be fine.
Suggested a change to the line below as well.
Co-authored-by: Mark Noonan <mark@cypress.io>
Finally, this is green. This was a bit painful... apparently missing a newline here: fce1b51 was causing CI to fail, without actually making it obvious why. Also, it wasn't failing locally. |
I tried installing Cypress 11 in a Cypress 9 project. If you open it in global mode, it says "You are in global mode. Please install Cypress 10 in your project to migrate".
I tested it out, I was able to migrate from Cypress 9 to Cypress 11 using the migration wizard.
We didn't really discuss if this should work (eg; should we force users to Cypress 10, then Cypress 11?) but it works great as is, I say we just make the minimal change, which is to update the language in the message.