New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: minor style updates & fix a windows test #24558
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix works, left comment about other wording.
I fixed the values being passed to Date.UTC that was a parameter to useTimeAgo. The |
Good catch @warrensplayer! We need to update the test for "11.0.0 Released just now" |
// First ensure the test is loaded | ||
cy.get('.passed > .num').should('contain', '--') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Race condition - sometimes the rest actually executes fast enough, and it's not --
, but the number of passes. So, better just verify the elements exist.
@@ -10,8 +10,6 @@ | |||
"vue": "^2.6.11" | |||
}, | |||
"devDependencies": { | |||
"@cypress/vue2": "file:../../../npm/vue2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't do what you expect on windows apparently. Also, seems like it isn't strictly required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messed around a bit to get windows to a reasonable state. There is some flake I could not solve, but it's windows only and the behaviors are working fine and verified via linux tests; I skipped them and created issues in the interest of getting this merged.
- Flaky test: "App: should re-query for executing runs" (windows mainly) #24575
- Flaky test: CT Mount - While hovering on Mount(), shows component on AUT #24579
Looks like there is still some flake, but far less than before.
I did skip ci
for the last commit. I checked CI before merging; everything is ✅ .
This PR fixes a windows Launchpad test that was failing due to config being slow to load. It's only possible to test the "record first run" prompt after a testing type has been chosen, which means the test needs to wait for the "Choose a Browser" screen to appear.
Also tweaks the border of the Major Version Welcome page to match the color in figma, and removes an extra overflow utility class that was causing a double scrollbar on Windows.
User facing changelog
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?