Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cy.origin time travel snapshots #24506

Closed
AtofStryker opened this issue Nov 2, 2022 · 2 comments · Fixed by #24519
Closed

Improve cy.origin time travel snapshots #24506

AtofStryker opened this issue Nov 2, 2022 · 2 comments · Fixed by #24519
Assignees
Labels
topic: cy.origin Problems or enhancements related to cy.origin command

Comments

@AtofStryker
Copy link
Contributor

What would you like?

Since Cypress 10.9.0, the implementation for cy.origin snapshots needs to be revisited. Currently, in transitionary states, the snapshots do not provide a lot of value and show a cypress-in-cypress snapshot. Ideally, a snapshot of the transition should be shown, and if not available, no snapshot should be taken.

Why is this needed?

This is important for cy.origin user experience to continue a good experience of time travel debugging

Other

No response

@AtofStryker AtofStryker self-assigned this Nov 2, 2022
@AtofStryker AtofStryker added the topic: cy.origin Problems or enhancements related to cy.origin command label Nov 2, 2022
@mschile mschile changed the title Spike into improving cy.origin time travel snapshots Improve cy.origin time travel snapshots Nov 7, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 7, 2022

The code for this is done in cypress-io/cypress#24519, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 10, 2022

Released in 11.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: cy.origin Problems or enhancements related to cy.origin command
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant