Skip to content

feat(breaking): 12.0 Release #24408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Dec 2, 2022
Merged

feat(breaking): 12.0 Release #24408

merged 54 commits into from
Dec 2, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Oct 26, 2022

BREAKING CHANGE: 12.0 release

⚠️ DO NOT SQUASH AND MERGE. USE A MERGE COMMIT

Blue F and others added 7 commits September 27, 2022 12:20
* feat: Error if command used inside .should() callback

* Update packages/driver/cypress/e2e/commands/assertions.cy.js

Co-authored-by: Zach Bloomquist <git@chary.us>

* Match error message and test

Co-authored-by: Zach Bloomquist <git@chary.us>
* fix: Make querystrings consistent

* fix conflicts.

Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Rachel <rachel@cypress.io>
BREAKING CHANGE: removed Cookies.defaults/preserveOnce, use cy.session instead
BREAKING CHANGE: removed experimentalSessionAndOrigin flag. testIsolation defaults to strict
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 26, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 3, 2022



Test summary

621 2 45 0Flakiness 6


Run details

Project cypress
Status Failed
Commit 8e422eb
Started Dec 5, 2022 1:40 PM
Ended Dec 5, 2022 1:56 PM
Duration 16:27 💡
OS Windows 10.0.17763
Browser Chrome 108

View run in Cypress Dashboard ➡️


Failures

cypress\e2e\runner\sessions.ui.cy.ts Failed
1 ... > successfully recreated session > has test error when validate has failing Cypress command
cypress\e2e\run-all-specs.cy.ts Failed
1 run-all-specs > can run all specs with filter and live-reloading

Flakiness

cypress\e2e\top-nav-launchpad.cy.ts Flakiness
1 ... > global mode > shows "continue" button after login if project selected
cypress\e2e\scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > vue3-vite-ts-unconfigured > scaffolds component testing for Vue 3 and Vite
cypress\e2e\create-from-component.cy.ts Flakiness
1 Create from component card > project with default spec pattern > runs generated spec
cypress\e2e\specs_list_latest_runs.cy.ts Flakiness
1 App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs
cypress\e2e\cypress-origin-communicator.cy.ts Flakiness
1 Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

mjhenkes and others added 12 commits November 4, 2022 08:24
* fix: remove server and route commands

* This won't totally pass but it's a step in the right direction.

* Should be down to only two failing tests due to abort.

* fix the alias.<thing> api for intercept to be equivalent to route.

* adjust timeouts to reduce flake, ideally

* skip xhr abort tests

* More clean up

* Increase timeout

* trick next version

* fix unit tests probably

* yeah sure

* Apply suggestions from code review

Co-authored-by: Blue F <blue@cypress.io>

* remove addXhrLog

* Remove more usage of XHR stemming from proxy-logging

* Remove a couple of files that found their way back with the merge from release/12.0.0

* remove more server types

* increase timeouts again to prevent flake

Co-authored-by: Blue F <blue@cypress.io>
Co-authored-by: Zach Bloomquist <git@chary.us>
…ranches. (#24594)

* testing circle config

* syntax?

* trying a straight up regex

* do regex right

* 1 or more digit
* fix: allow intercept aliases to yield their value on a get

* break caching for intercepted responses

* Revert "break caching for intercepted responses"

This reverts commit d625013.

* return the last request, not all of them
* feat: Commands.addSelector, and migrate .get() to be a selector

* Fix for failed tests

* Last test fix

* More test fixes

* Self review changes

* Remove the concept of prevSubject from selectors entirely

* Rename addSelector to addQuery

* Quick fix for last commit

* Fix TS

* Fix merge from develop

* Add types and other review updates

* Increase timeout to try fixing flakiness

* Rename addQuery to _addQuery

* Fix typo in previous commit

* Fix TS

* Include AUT assertion in cy.get()

* Fix for previous commit

* Review feedback

* Minor test improvement

* Swifter failure on sizzle syntax error

* Better solution for refetching current subject in verifyUpcomingAssertions

* Command IDs now include their chainerId

* Revert "chore: Revert "feat: _addQuery() (#23665)" (#24022)"

This reverts commit f399994.

* feat: move .contains() and .shadow() to be queries; remove cy.ng() (#23791)

* First stab at removing old .get() implementation

* Fix TS and a couple of tests

* Fix tests and TS

* Fix case-sensitivity for .contains()

* Stop TS complaining

* Rework cy-contains jquery expression

* Add comments, make ts happy

* Fix one test, review feedback

* Review updates

* Fix additional tests

* Fix accidental deletion of vital code

* One more try at getting logs right

* Fix race condition in cross-origin .contains

* Add commented out test to ensure .within() works properly with selectors

* Fix for sessions + query subject chaining

* Fix mixing .within() shadow DOM and .contains() in same chainer

* One more attempt at .within + .contains

* Fix rebase commits

* feat: addQuery Remaining Queries (#24203)

* First stab at removing old .get() implementation

* Fix TS and a couple of tests

* Fix tests and TS

* Fix case-sensitivity for .contains()

* Stop TS complaining

* Rework cy-contains jquery expression

* Add comments, make ts happy

* Fix one test, review feedback

* Review updates

* Fix additional tests

* Fix accidental deletion of vital code

* One more try at getting logs right

* Fix race condition in cross-origin .contains

* Add commented out test to ensure .within() works properly with selectors

* Fix for sessions + query subject chaining

* Fix mixing .within() shadow DOM and .contains() in same chainer

* One more attempt at .within + .contains

* Fix rebase commits

* Update many commands to be queries; improve log message around invalid subjects

* Update connectors, location, focused and window commands to queries

* Return noop to a command and not a query (to avoid implicit assertions)

* More test fixes

* Fix test failures

* Fix for weird-ass frontend-component test

* Error message improvements

* Fix for broken system test

* Update withinSubject to use subject chain

* Test clarifications

* Unbreak cypress-testing-library via withinState backwards compatibility

* Typo in last commit

* Improvement for assertion following failed traversal

* feat: Fix detached DOM errors for all Cypress commands (#24417)

* First stab at removing old .get() implementation

* Fix TS and a couple of tests

* Fix tests and TS

* Fix case-sensitivity for .contains()

* Stop TS complaining

* Rework cy-contains jquery expression

* Add comments, make ts happy

* Fix one test, review feedback

* Review updates

* Fix additional tests

* Fix accidental deletion of vital code

* One more try at getting logs right

* Fix race condition in cross-origin .contains

* Add commented out test to ensure .within() works properly with selectors

* Fix for sessions + query subject chaining

* Fix mixing .within() shadow DOM and .contains() in same chainer

* One more attempt at .within + .contains

* Fix rebase commits

* Update many commands to be queries; improve log message around invalid subjects

* Update connectors, location, focused and window commands to queries

* Return noop to a command and not a query (to avoid implicit assertions)

* More test fixes

* Fix test failures

* Fix for weird-ass frontend-component test

* Error message improvements

* Fix for broken system test

* Update withinSubject to use subject chain

* Test clarifications

* Unbreak cypress-testing-library via withinState backwards compatibility

* Typo in last commit

* Improvement for assertion following failed traversal

* WIP adding query support to

* More work on actionability + detached dom

* Fix TS, rename _addQuery to addQuery

* Another try to fix types

* Fix lint

* Fix for bad merge

* Fixes for a couple more tests

* Increase timeout 50ms -> 100ms on certain tests failing in CI

* Switch to new branch of cypress-testing-library

* Update lockfile

* Fix yarn.lock with latest version of forked testing-library

* More test fixes

* Fix TS again

* Increase test assertion timeout so it passes on slow browsers (webkit)

* Apply suggestions from code review

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Zach Bloomquist <git@chary.us>

* More review changes

* Fix selectFile tests based on updated error message

* Improve types and type comments for Commands.add

* Undo change to Commands.add types

* Update yarn lockfiles again

* Remove overwriteQuery from Cy12; .focused() now respects passed in timeout

* Update cli/types/cypress.d.ts

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

* Restore .uncheck() tests

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Zach Bloomquist <git@chary.us>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

* Fix for hanging driver test after merge

* Fix for app component test

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Co-authored-by: Zach Bloomquist <git@chary.us>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
…ess-io/cypress into merge-develop-v12-2022-11-14-take-2
mjhenkes and others added 16 commits November 22, 2022 12:39
Co-authored-by: Ben M <benm@cypress.io>
Co-authored-by: Dariusz Czajkowski <darek@darek.dev>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
Co-authored-by: Adam Stone <adams@cypress.io>
BREAKING CHANGE: Cookie commands now use the the hostname and not the superdomain for the domain by default. This may affect what cookies are returned/set/cleared by cookie commands.
* Update workflows.yml

Build artifacts

* Empty-Commit
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Closes undefined
…24697)

* fix: Improve TypeScript support for custom queries

* Typo fix

* Fix TS more

* Move 'ensures' off of cy and onto Cypress

* Type fixes

* One missed replacement

* Test fixes

* Properly pass in  to ensureRunnable

* Add .eslintignores to quiet down warnings

* Review feedback

* Update cli/types/cypress.d.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
…<input> (#24886)

* fix: Fix typing into wrapper elements

* run ci

Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com>
…rt within cy.origin (#24931)

* adding experimentalOriginDependencies flag

* update system tests
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
Co-authored-by: Mark Noonan <mark@cypress.io>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com>
Co-authored-by: Zach Bloomquist <git@chary.us>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Co-authored-by: Feng Yu <abcfy2@users.noreply.github.com>
@mjhenkes mjhenkes self-requested a review December 2, 2022 14:02
AtofStryker and others added 6 commits December 2, 2022 09:06
* chore: update cross_origin_command to point to new v12 docs with cy.origin explainer

* chore: add snapshot-meta cache

* chore: update link

Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
* feat: 12.0.0 Welcome Page

* Update packages/launchpad/src/migration/MajorVersionWelcome.vue

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>

* add v12 release date

* fix space between external link & period

* fix period space issue? & add onlink

* Update packages/launchpad/src/migration/MajorVersionWelcome.vue

Co-authored-by: Mark Noonan <mark@cypress.io>

* fix ci scroll issue?

Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Mark Noonan <mark@cypress.io>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
* feat(12): change testIsolation values from on/off to true/false

* missed

* Update cli/types/cypress.d.ts

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
…#24952)

* fix: exclude node_modules from cross-origin-callback-loader

* Update system-tests/test/cy_origin_error_spec.ts

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

* Update system-tests/projects/origin-dependencies/.gitignore

Co-authored-by: Ryan Manuel <ryanm@cypress.io>

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
* chore: run tests for cy.origin

* enable experimentalModifyObstructiveThirdpartyCode

* Disabling cleaning subjects

* Bump memory for driver integration tests

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
@mjhenkes mjhenkes merged commit ed0668e into develop Dec 2, 2022
@mjhenkes mjhenkes deleted the release/12.0.0 branch December 2, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants