Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface "recreated" session visually #24207

Closed
nagash77 opened this issue Oct 11, 2022 · 2 comments · Fixed by #24592
Closed

Surface "recreated" session visually #24207

nagash77 opened this issue Oct 11, 2022 · 2 comments · Fixed by #24592
Assignees

Comments

@nagash77
Copy link
Contributor

Hard to know that because the first validate will fail, but sessions will recover and recreate the session and their test will pass and the command is visually green.

Some of this problem could be obviated by making the “recreated” state more of a warning under the assumption that it should be fairly rare and we should draw the user to the problem more aggressively
1. ideas: make the row amber/yellow/red, make the session state indicate more visible, possibly add a warning icon, etc

@nagash77 nagash77 transferred this issue from cypress-io/cypress-documentation Oct 11, 2022
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Nov 8, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 16, 2022

The code for this is done in cypress-io/cypress#24592, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Nov 16, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 22, 2022

Released in 11.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v11.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants