Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login/utm param bug fixes and test coverage #23787

Merged
merged 15 commits into from Sep 12, 2022

Conversation

marktnoonan
Copy link
Contributor

@marktnoonan marktnoonan commented Sep 12, 2022

User facing changelog

Users can now log in from the "Choose a browser" page of the Launchpad even if a browser is not open.

Additional details

This PR combines a few related changes for login and UTM parameters. It addresses 4 things:

  1. Can't log in from the "Choose a browser" page of the launchpad
  2. Hardcoded UTM parameters in some components that need to be contextual instead
  3. Some testing TODOs that I hit when looking for test coverage related to UTM params, where we just were not testing them yet.
  4. Some inaccuracies in tests themselves, for example testing the header login button on the "logged out" state of the Runs page, not the in-page login button that's supposed to be there

Steps to test

  • In the Launchpad, advance to the "Choose a browser" page but do not open a browser. Use the Log In button in the header to log in. It should complete the login process and refocus the launchpad.
  • For the UTM params, these are tedious to test manually, but in many cases can be seen with DEBUG logs turned on, so spot checking logging in and creating a project from various pages would be good.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 12, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 12, 2022



Test summary

40019 0 3346 0Flakiness 3


Run details

Project cypress
Status Passed
Commit 9b8b06f
Started Sep 12, 2022 7:57 PM
Ended Sep 12, 2022 8:13 PM
Duration 15:54 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

config_env.cy.ts Flakiness
1 cy.origin- Cypress.config() > serializable > overwrites different values in secondary, even if the Cypress.config() value does not exist in the primary
commands/location.cy.ts Flakiness
1 cy.origin location > .hash()
2 cy.origin location > #consoleProps > .location()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launchpad - login doesn't work from "Choose a browser" page if browser isn't open yet
3 participants