Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated specs list search in 10.6 is not working with forward slash #23426

Closed
Deop opened this issue Aug 18, 2022 · 5 comments · Fixed by #23776
Closed

Updated specs list search in 10.6 is not working with forward slash #23426

Deop opened this issue Aug 18, 2022 · 5 comments · Fixed by #23776
Assignees
Labels
CT Issue related to component testing

Comments

@Deop
Copy link

Deop commented Aug 18, 2022

Current behavior

In 10.6 specs list search was updated to work file path. While it is working now if path contains back slash, it does NOT work with forward slashes in the path. For example if I copy file path from IntelliJ (on Windows) it copies it with forward slashes, so I can't just copy-paste file path but need to modify it with forward slashes

Desired behavior

Specs list search works with both forward or back slashes

Test code to reproduce

Just try search for files with path containing forward slash
image
image

Cypress Version

10.6.0

Node version

16.7.0

Operating System

Windows 10

Debug Logs

No response

Other

No response

@mschile mschile added triage and removed triage labels Aug 18, 2022
@nagash77 nagash77 added type: enhancement Requested enhancement of existing feature CT Issue related to component testing and removed type: enhancement Requested enhancement of existing feature labels Aug 18, 2022
@baus
Copy link
Collaborator

baus commented Aug 26, 2022

@lmiller1990
Copy link
Contributor

We should just normalize all slashes to be the same (say / since we generally use posix everywhere else to avoid this problem).

@marktnoonan
Copy link
Contributor

@lmiller1990 I agree, though for specs in particular we do not normalize paths on the client as far as I recall. Without digging in more, on Windows, we could still replace / with \ when used in searches. Though I'd prefer normalized paths for sure.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 12, 2022

The code for this is done in cypress-io/cypress#23776, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2022

Released in 10.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CT Issue related to component testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants