New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: windows CI with Vite 3 #23052
fix: windows CI with Vite 3 #23052
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
if (this._testingType === 'component') { | ||
this.checkDependenciesForComponentTesting() | ||
await this.checkDependenciesForComponentTesting() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s either convert everything to async or have this use then. Errors clauses by checkDependenciesForComponentTesting will be swallowed like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. I was wrong about this.
User facing changelog
N/A
Additional details
Couple things here:
patch-package
for now.patch-package
.fs.readJsonSync
tofs.readJson
to hopefully reduce some flake - many synchronous file system reads can slow down CI, especially windows.Steps to test
N/A
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?