Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows CI with Vite 3 #23052

Merged
merged 7 commits into from Aug 2, 2022
Merged

fix: windows CI with Vite 3 #23052

merged 7 commits into from Aug 2, 2022

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Aug 2, 2022

User facing changelog

N/A

Additional details

Couple things here:

  1. Patch so windows CI can run with Vite 3. We updated to Vite 3 in feat: update to Vite 3 #22915.
  1. Converted a bunch of fs.readJsonSync to fs.readJson to hopefully reduce some flake - many synchronous file system reads can slow down CI, especially windows.
  2. Added some timeouts to reduce flake.

Steps to test

N/A

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 marked this pull request as ready for review August 2, 2022 04:00
@lmiller1990 lmiller1990 requested review from a team as code owners August 2, 2022 04:00
@lmiller1990 lmiller1990 requested review from mjhenkes, ZachJW34 and tbiethman and removed request for a team August 2, 2022 04:00
@cypress
Copy link

cypress bot commented Aug 2, 2022



Test summary

4377 0 51 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 5ac9b5b
Started Aug 2, 2022 7:30 AM
Ended Aug 2, 2022 7:41 AM
Duration 11:28 💡
OS Linux Debian - 11.3
Browser Firefox 99

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

if (this._testingType === 'component') {
this.checkDependenciesForComponentTesting()
await this.checkDependenciesForComponentTesting()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s either convert everything to async or have this use then. Errors clauses by checkDependenciesForComponentTesting will be swallowed like this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. I was wrong about this.

@mjhenkes mjhenkes merged commit ee17719 into develop Aug 2, 2022
@mjhenkes mjhenkes deleted the lmiller/windows-vite-fix branch August 2, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove fs.sync calls from framework detection
5 participants