chore: reverting #22742 #23047
Merged
chore: reverting #22742 #23047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
mjhenkes
requested review from
tbiethman and
marktnoonan
and removed request for
a team
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||
lmiller1990
approved these changes
Aug 1, 2022
marktnoonan
approved these changes
Aug 1, 2022
BlueWinds
added a commit
that referenced
this pull request
Aug 2, 2022
1 task
BlueWinds
pushed a commit
that referenced
this pull request
Aug 3, 2022
* Revert "chore: reverting #22742 (#23047)" This reverts commit 51ef99a. * Fix for aliases when .then() is in the chain * Run all tests on branch * Fix silly mistake * Fix broken test (again) * Update packages/driver/cypress/e2e/cypress/cy.cy.js Co-authored-by: Matt Henkes <mjhenkes@gmail.com> Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
Reverting #22742, this commit unknowingly caused a test failure in the 'test-binary-against-todomvc-firefox' test in develop.
Steps to test
Before (develop): test-binary-against-todomvc-firefox
After (this PR): test-binary-against-todomvc-firefox
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?