Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating run binary CI scripts to support external contributors #23021

Merged
merged 2 commits into from Jul 29, 2022

Conversation

tbiethman
Copy link
Contributor

@tbiethman tbiethman commented Jul 29, 2022

Contributor PRs are failing the test-binary-against-kitchensink job in CI due to an invalid curl for the node sourcing script. I added a fallback for branches matching external contributor branches to pull directly from develop.

There's probably a better way to go about this in general, but this is a quick fix for the PRs open now.

User facing changelog

N/A

Additional details

Steps to test

I validated the script locally. This PR is green.

How has the user experience changed?

PR Tasks

  • [n/a] Have tests been added/updated?
  • [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 29, 2022



Test summary

37829 0 464 0Flakiness 10


Run details

Project cypress
Status Passed
Commit ae3f485
Started Jul 29, 2022 8:44 PM
Ended Jul 29, 2022 9:01 PM
Duration 17:20 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs Method, Status, URL, and XHR
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tbiethman tbiethman merged commit 964ac37 into develop Jul 29, 2022
@tbiethman tbiethman deleted the tbiethman/contrib-ci-fix branch July 29, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants