Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Standardize colors for runs in queued status #23015

Merged
merged 2 commits into from Jul 29, 2022

Conversation

mike-plummer
Copy link
Contributor

User facing changelog

  • Fix icon colors in "Latest Runs" section for queued/pending runs

Additional details

Also updating the "queued" icon's SVG to support the icon-light* and icon-dark* style pattern if it gets used elsewhere

Steps to test

How has the user experience changed?

Before
Latest run icon for "Queued" status is lighter gray than dots
178307071-472aa381-23cf-48ce-a22d-2c500d720928

After
Latest run icon for "Queued" status is same gray color as dots
Screen Shot 2022-07-29 at 8 38 27 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 29, 2022



Test summary

37837 0 456 0Flakiness 10


Run details

Project cypress
Status Passed
Commit 126f902
Started Jul 29, 2022 2:12 PM
Ended Jul 29, 2022 2:32 PM
Duration 20:03 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
5 ... > logs Method, Status, URL, and XHR
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mike-plummer mike-plummer marked this pull request as ready for review July 29, 2022 14:43
@mike-plummer mike-plummer merged commit 91de9cf into develop Jul 29, 2022
@mike-plummer mike-plummer deleted the 22601-queued-status-icon-color branch July 29, 2022 17:54
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Released in 10.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queued small status dot updates
3 participants