New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove isAUTFrame qualification from cross origin cookie check #22963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
requested review from
chrisbreiding,
mjhenkes,
AtofStryker and
emilyrohrbough
July 27, 2022 22:25
Thanks for taking the time to open a PR!
|
emilyrohrbough
approved these changes
Jul 27, 2022
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mschile
changed the title
bug: Remove isAUTFrame qualification from cross origin cookie check
fix: Remove isAUTFrame qualification from cross origin cookie check
Jul 27, 2022
AtofStryker
approved these changes
Jul 28, 2022
This was referenced Jul 28, 2022
chrisbreiding
approved these changes
Jul 28, 2022
mjhenkes
approved these changes
Jul 29, 2022
This was referenced Jul 29, 2022
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimentalSessionAndOrigin
is enabled #22952cy.origin
integration tests for Google Authentication #21474User facing changelog
Fixes issue where cookies were not handled within
cy.origin
for requests other than the AUT page request.Additional details
Removed the
isAUTFrame
check to determine if cross-origin cookie handling is needed in theresponse-middleware
. This will allow all cross-origin requests (e.g. XHR, fetch, etc) with cookies to be handled instead of just the AUT page request.Steps to test
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?