Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove isAUTFrame qualification from cross origin cookie check #22963

Merged
merged 10 commits into from Jul 29, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Jul 27, 2022

User facing changelog

Fixes issue where cookies were not handled within cy.origin for requests other than the AUT page request.

Additional details

Removed the isAUTFrame check to determine if cross-origin cookie handling is needed in the response-middleware. This will allow all cross-origin requests (e.g. XHR, fetch, etc) with cookies to be handled instead of just the AUT page request.

Steps to test

How has the user experience changed?

Before:
Screen Shot 2022-07-27 at 4 19 32 PM

After:
Screen Shot 2022-07-27 at 4 18 07 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 27, 2022

Thanks for taking the time to open a PR!

@mschile mschile removed the request for review from a team July 27, 2022 22:25
@cypress
Copy link

cypress bot commented Jul 27, 2022



Test summary

37833 0 464 0Flakiness 8


Run details

Project cypress
Status Passed
Commit 88775c9
Started Jul 29, 2022 9:54 PM
Ended Jul 29, 2022 10:10 PM
Duration 15:50 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mschile mschile changed the title bug: Remove isAUTFrame qualification from cross origin cookie check fix: Remove isAUTFrame qualification from cross origin cookie check Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants