Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't include workspaces.nohoist in public NPM package #22365

Merged
merged 1 commit into from Jun 17, 2022

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 16, 2022

User facing changelog

Fixed an issue causing a "nohoist config is ignored" warning when installing cypress with yarn.

Additional details

Steps to test

Install latest prerelease comment on this branch on Linux, note there is no warning.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 16, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig requested a review from marktnoonan June 16, 2022 19:32
@cypress
Copy link

cypress bot commented Jun 16, 2022



Test summary

37553 0 454 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 0462489
Started Jun 16, 2022 7:38 PM
Ended Jun 16, 2022 7:56 PM
Duration 17:19 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig marked this pull request as ready for review June 16, 2022 20:48
@flotwig flotwig requested a review from a team as a code owner June 16, 2022 20:48
@flotwig flotwig requested review from jennifer-shehane and ryanthemanuel and removed request for a team and jennifer-shehane June 16, 2022 20:48
Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is there a way to write a test for this change?

@flotwig
Copy link
Contributor Author

flotwig commented Jun 17, 2022

@ryanthemanuel I don't see an obvious way to test it since it's in the build step. I could add an assertion in buiild.js or post-build.js, but it would be overly unit testy imo.

I think this script should be updated in general, we shouldn't need to do all this wacky merging of 2 package.jsons, I think all of the should be all in one place as much as possible. So no _.extend(json. We'd be better off since changes to cli/package.json couldn't have this unintended impact.

@ryanthemanuel
Copy link
Collaborator

@ryanthemanuel I don't see an obvious way to test it since it's in the build step. I could add an assertion in buiild.js or post-build.js, but it would be overly unit testy imo.

I figured as such. Approved!

Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flotwig flotwig merged commit b865fd4 into develop Jun 17, 2022
@flotwig flotwig deleted the issue-22147-nohoist branch June 17, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nohoist config is ignored
3 participants