Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows #22234

Merged
merged 12 commits into from Jun 10, 2022
Merged

fix: windows #22234

merged 12 commits into from Jun 10, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Jun 9, 2022

User facing changelog

N/A

Additional details

The main goal here is to fix flaky tests in windows. This was accomplished via:

  • Bump the resource class of the windows executor
  • Add some waits to a few places that seem to rely on postFragment subscriptions

Neither of these are ideal solutions; however, they don't appear to be new problems (I can recreate them in at least v10.0.3). Consequently we want to make the builds more stable and follow up on these issues later.

Steps to test

Check that CI succeeds

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 9, 2022

Thanks for taking the time to open a PR!

@ryanthemanuel ryanthemanuel changed the title fix windows fix: windows Jun 9, 2022
@cypress
Copy link

cypress bot commented Jun 9, 2022



Test summary

37553 0 454 0Flakiness 4


Run details

Project cypress
Status Passed
Commit 94f46e4
Started Jun 10, 2022 1:04 PM
Ended Jun 10, 2022 1:20 PM
Duration 16:33 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/origin/commands/actions.cy.ts Flakiness
1 cy.origin actions > #consoleProps > .selectFile()
2 cy.origin actions > #consoleProps > .submit()
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will find out why #22118 has (frustrating) windows on CI fails. I'm fairly sure they are just flake, they've passed before, but I'll find out.

requires:
- windows-build

- create-build-artifacts:
<<: *full-windows-workflow-filters
name: windows-create-build-artifacts
executor: windows
resource_class: windows.medium
resource_class: windows.xlarge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little unsettling that we don't know why this is required, but glad to have windows CI back to green.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. 😕

@@ -32,9 +32,6 @@ import {
} from '../sources/migration'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify for reviewers: every file change below this line is reverted from #22118 and you don't need to review it to review this PR.

@lmiller1990
Copy link
Contributor

lmiller1990 commented Jun 10, 2022

Hey @ryanthemanuel I do not think we need to revert #22118 anymore - can you just merge this commit and it'll be fine. I checked out #22118, merged this in, added that one commit, and pushed - CI is green. Link to CI run with 100% windows tests passing first run.

@ryanthemanuel ryanthemanuel marked this pull request as ready for review June 10, 2022 13:55
@ryanthemanuel ryanthemanuel merged commit 600daef into develop Jun 10, 2022
@ryanthemanuel ryanthemanuel deleted the ryanm/playground/fix-windows-build branch June 10, 2022 14:04
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants