Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Volar identifier for VSCode Marketplace #22189

Merged
merged 6 commits into from Jun 10, 2022

Conversation

astone123
Copy link
Contributor

Additional details

When installing recommended VSCode extensions in my IDE, I noticed this warning

Screen Shot 2022-06-08 at 9 37 13 AM

It looks like the identifier for the Volar extension changed from johnsoncodehk.volar to vue.volar at some point. This PR updates the recommended extensions to use the new identifier so that VSCode can find the Volar extension when installing recommended extensions. The links to the VSCode marketplace on the web seemed to still work, but I updated those as well just so that we're using the correct identifier.

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@astone123 astone123 self-assigned this Jun 8, 2022
@astone123 astone123 requested review from a team as code owners June 8, 2022 13:53
@astone123 astone123 requested review from jennifer-shehane and removed request for a team June 8, 2022 13:53
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 8, 2022



Test summary

4876 0 59 0Flakiness 1


Run details

Project cypress
Status Passed
Commit 112946b
Started Jun 9, 2022 5:53 PM
Ended Jun 9, 2022 6:09 PM
Duration 15:24 💡
OS Linux Debian - 10.11
Browser Electron 100

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tbiethman tbiethman self-requested a review June 8, 2022 15:42
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR @astone123

@astone123
Copy link
Contributor Author

@mike-plummer @flotwig any idea why Percy is showing visual changes for this? Seems like there shouldn't be any based on my changes

@marktnoonan
Copy link
Contributor

The changes in Percy are all flake, some have to do with loaders/spinners, a lot are an element in the header that actually is flaky in the launchpad and has a ticket. Percy is great but with the new app some of the snapshots haven't been given enough attention around exactly at what moment to take the snapshot, or what elements to block out. So we get quite a bit of noise in the diffs based on the position of a spinner or the precise status in the command log, which is based on performance at the time, and not deterministic. There's some WIP out there that will address a lot of this, though I bet we can make small improvements before that lands.

@lmiller1990
Copy link
Contributor

Nice, going to merge - windows CI is red here, but I'm confident the errors are resolved in #22234 (review), and you did not introduce any just by changing some markdown files.

@lmiller1990 lmiller1990 merged commit 7a0baf9 into develop Jun 10, 2022
@lmiller1990 lmiller1990 deleted the volar-marketplace-identifier branch June 10, 2022 06:09
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
* Update Volar identifier for VSCode Marketplace

* chore: Update Volar identifier for VSCode Marketplace

Co-authored-by: Zach Bloomquist <git@chary.us>
Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants