New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AUT URL in runner header links to application URL #22171
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it out, works great 👍 let's ship it.
Nice! @canourrea23 mentioned that somebody was asking for this specific thing. Looks good, I approved the Percy diff. Adding @tbiethman to review since our current convention is "one ✅ from CT team and one ✅ from E2E team". |
<a | ||
target="_blank" | ||
:href="autStore.url" | ||
class="mr-12px max-w-100% grid text-indigo-500 hocus-link-default items-center truncate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick smoke test for the truncation, I was going to say it's not working like expected:
But it's doing the same in develop:
If we want to truncate with ellipses here, I think we just need to remove the grid
and items-center
classes and add self-center
to hook into the flex positioning provided by the container. Seems like grid conflicts with the truncation:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch! I made the update
If you merge in develop, windows CI should start working again. |
Going to merge this - windows fails, but those are fixed in #22234 (review), I don't think you've introduced any here. |
User facing changelog
Runner header now links to application URL while running e2e tests
Additional details
Before v10, the application URL in the AUT header was a link that the user could click which would open the current application URL in a new tab. That functionality was lost during updates to the header for v10.
Steps to test
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation
?type definitions
?