Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AUT URL in runner header links to application URL #22171

Merged
merged 9 commits into from Jun 10, 2022

Conversation

astone123
Copy link
Contributor

@astone123 astone123 commented Jun 7, 2022

User facing changelog

Runner header now links to application URL while running e2e tests

Additional details

Before v10, the application URL in the AUT header was a link that the user could click which would open the current application URL in a new tab. That functionality was lost during updates to the header for v10.

Steps to test

  1. Run an e2e test
  2. In the header "address bar", click the application URL
  3. Verify that a new tab is opened at the application URL that was open in the runner during your test

How has the user experience changed?

Before
Screen Shot 2022-06-07 at 3 38 06 PM

After
Screen Shot 2022-06-07 at 3 32 00 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@astone123 astone123 self-assigned this Jun 7, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2022

CLA assistant check
All committers have signed the CLA.

@astone123 astone123 changed the title 21823 aut url link fix: AUT URL in runner header links to application URL Jun 7, 2022
@astone123 astone123 marked this pull request as ready for review June 7, 2022 21:02
@cypress
Copy link

cypress bot commented Jun 8, 2022



Test summary

37553 0 454 0Flakiness 3


Run details

Project cypress
Status Passed
Commit 8d03268
Started Jun 9, 2022 1:09 PM
Ended Jun 9, 2022 1:26 PM
Duration 16:24 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

next.cy.ts Flakiness
1 Working with next-12.1.6 > should detect new spec
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, works great 👍 let's ship it.

@marktnoonan
Copy link
Contributor

Nice! @canourrea23 mentioned that somebody was asking for this specific thing.

Looks good, I approved the Percy diff. Adding @tbiethman to review since our current convention is "one ✅ from CT team and one ✅ from E2E team".

<a
target="_blank"
:href="autStore.url"
class="mr-12px max-w-100% grid text-indigo-500 hocus-link-default items-center truncate"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick smoke test for the truncation, I was going to say it's not working like expected:

Screen Shot 2022-06-08 at 9 06 58 AM

But it's doing the same in develop:

Screen Shot 2022-06-08 at 9 13 06 AM

If we want to truncate with ellipses here, I think we just need to remove the grid and items-center classes and add self-center to hook into the flex positioning provided by the container. Seems like grid conflicts with the truncation:

Screen Shot 2022-06-08 at 9 21 34 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch! I made the update

@lmiller1990
Copy link
Contributor

If you merge in develop, windows CI should start working again.

@lmiller1990
Copy link
Contributor

Going to merge this - windows fails, but those are fixed in #22234 (review), I don't think you've introduced any here.

@lmiller1990 lmiller1990 merged commit 85f002f into develop Jun 10, 2022
@lmiller1990 lmiller1990 deleted the 21823-aut-url-link branch June 10, 2022 06:31
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
)

* Add failing test

* Update AUT URL display to link

* fix: Fix header AUT URL truncation

* fix: Adjust line height so that lower-hanging characters don't get cut off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AUT header - URL should be a link
5 participants