fix: restart Cypress server and browser on baseUrl change #22154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthemanuel
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
ryanthemanuel
commented
Jun 7, 2022
| @@ -190,7 +190,7 @@ describe('Choose a Browser Page', () => { | |||
| cy.get('h1').should('contain', 'Choose a Browser') | |||
There was a problem hiding this comment.
These changes are for unrelated flake.
ryanthemanuel
commented
Jun 7, 2022
ryanthemanuel
commented
Jun 7, 2022
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
ryanthemanuel
changed the title
ryanthemanuel
requested review from
ZachJW34
and removed request for
jennifer-shehane
tgriesser
approved these changes
Jun 7, 2022
ZachJW34
approved these changes
Jun 8, 2022
lmiller1990
approved these changes
Jun 9, 2022
BeijiYang
pushed a commit
to BeijiYang/cypress
that referenced
this pull request
Jun 23, 2022
…#22154) * fix: restart server on baseUrl change * Rework how baseUrl works * Refactor how we determine if we should ping the base url * Fix test * Update packages/launchpad/cypress/e2e/choose-a-browser.cy.ts * Update packages/launchpad/cypress/e2e/choose-a-browser.cy.ts Co-authored-by: Matt Henkes <mjhenkes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
The
baseUrlconfig option will now restart the Cypress server automatically when it is updated in a Cypress config file.Additional details
There are several things that use the baseUrl during the server's initialization like the browser and xhr urls and remote states. In order to properly ensure they are reinitialized appropriately, we will need to restart the server. Thus, we change
baseUrl'srequireRestartOnChangeproperty toserver.Steps to test
cypress opena project with abaseUrlbaseUrlin cypress.config.jsbaseUrlHow has the user experience changed?
Before
baseUrl.-.Before.mov
After
baseUrl.-.After.mov
PR Tasks
cypress-documentation?type definitions?