Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMFILE eventually crashes cypress open on Linux #22023

Closed
flotwig opened this issue Jun 2, 2022 · 3 comments · Fixed by #22175
Closed

EMFILE eventually crashes cypress open on Linux #22023

flotwig opened this issue Jun 2, 2022 · 3 comments · Fixed by #22175
Assignees
@flotwig
Labels
type: bug v10.0.0 🐛 Issue present since 10.0.0

Comments

@flotwig
Copy link
Contributor

flotwig commented Jun 2, 2022 •
edited

Current behavior

If you're near the open file limit, cypress will crash with an EMFILE error when you try to use it.
image

Since it's EMFILE (too many open files) and not an error about "too many file watchers", I think we are either accidentally opening way too many files, or are not using fs-extra's EMFILE queuing like we should be, or probably both.

Desired behavior

Don't crash

Test code to reproduce

--

Cypress Version

10.0.0

Other

No response
@flotwig flotwig added type: bug v10.0.0 🐛 Issue present since 10.0.0 labels Jun 2, 2022
@mjhenkes
Copy link
Member

mjhenkes commented Jun 6, 2022

Related: #22028

@flotwig flotwig mentioned this issue Jun 8, 2022
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: to do labels Jun 8, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 16, 2022

The code for this is done in cypress-io/cypress#22175, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jun 16, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 21, 2022

Released in 10.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flotwig flotwig

Labels
type: bug v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retry on EMFILE always, lint sync FS calls cypress-io/cypress
3 participants
@flotwig @jennifer-shehane @mjhenkes