Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording of 'rename specs' area when the specs are not actually being renamed #21926

Closed
sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #22325
Closed

Update wording of 'rename specs' area when the specs are not actually being renamed #21926

sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #22325

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

I know this step is for renaming and moving but it feels odd to have everything say ‘rename’ when in this case there isn’t a rename and just a move:

Screen Shot 2022-05-19 at 2 07 18 PM

https://cypressio.slack.com/archives/C02MYBT9Y5S/p1652990922196199

Acceptance Criteria

If we are not renaming the spec extension (like for an existing Dashboard project)

  1. Have heading say ‘Move existing specs’
  2. Have sub description say ‘In this step, we’ll automatically move your existing spec files.
  3. Remove the sub-heading in the content that says ‘We recommend automatically…..etc'

┆Issue is synchronized with this Jira Task by Unito
┆Attachments: Screen Shot 2022-05-19 at 2.07.18 PM.png
┆author: Matthew Schile
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1801
┆priority: Medium
┆sprint: Fast Follows 1
┆taskType: Task

@lmiller1990
Copy link
Contributor

I thought this was a quick win but it's actually quite involved - we need a lot of conditionals, and there's not an easy way to know if we are doing a rename or a move (or both) - eg, there's no "is renaming" or "is moving" flag. I think the value of the recommended change in the acceptance criteria relative to the actual work involved and the impact is not worth it.

Instead, I changed it to be generic phrase that works for both rename and/or move. I think this is good enough to make the actual intent clear (we are changing to specs to match our convention) without been confusing.

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: review and removed stage: to do stage: needs review The PR code is done & tested, needs review labels Jun 15, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 16, 2022

The code for this is done in cypress-io/cypress#22325, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@emilyrohrbough
Copy link
Member

This was released in 10.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants