Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate how to get to Specs Page from Runner (minor style tweaks to sidebar) #21873

Closed
sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #22069
Closed

Indicate how to get to Specs Page from Runner (minor style tweaks to sidebar) #21873

sync-by-unito bot opened this issue May 30, 2022 · 3 comments · Fixed by #22069
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Summary

The navigation item in the left hand menu that goes to Specs is styled in an “inert” state, as the active item in the menu.

During the bug hunt, several Cypress employees on a video call with me could not see how to get back to the specs list from the runner, which is fair since the link that navigates there is not styled to be clickable (other links have cursor: pointer and hover states, this does not, since we are already inside that part of the app). This video shows the problem in more detail:

https://www.loom.com/share/f95449b235474cf2b2d0ef096122c764

The fix here is small: since every item in the side bar is a valid navigation target from the Spec Runner, they should all look and behave the same way so the user knows it is valid to click any of the three items, so we should turn off the “active” state of the spec item.

This was part of the feedback noted in https://cypress-io.atlassian.net/browse/UNIFY-1667 - but the title of that ticket would make it harder to track.

Acceptance Criteria

  • Specs List item in the navigation should only be active when on the Specs List page, not the runner

Resources

Any Notion documents, Google documents, Figma Boards

┆Issue is synchronized with this Jira Task by Unito
┆author: Mark Noonan
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1688
┆priority: Medium
┆sprint: Fast Follows 1
┆taskType: Task

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 30, 2022

➤ Mark Noonan commented:

Chris Baus Jennifer Shehane I see this one as pretty high priority, especially with the specs list defaulting to closed.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 3, 2022

The code for this is done in cypress-io/cypress#22069, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 6, 2022

Released in 10.0.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants