Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#21211 broke the build for external contributors. #21284

Closed
sainthkh opened this issue May 2, 2022 · 3 comments · Fixed by #21292
Closed

#21211 broke the build for external contributors. #21284

sainthkh opened this issue May 2, 2022 · 3 comments · Fixed by #21292
Assignees
@flotwig
Labels
process: build Related to our internal build process

Comments

@sainthkh
Copy link
Contributor

sainthkh commented May 2, 2022 •
edited

Current behavior

After #21211, the build fails for external contributors. It might be because they don't have access to process.env.CIRCLE_INTERNAL_CONFIG.

Desired behavior

Build works for everyone.

Test code to reproduce

See #21197, #21283.

Cypress Version

Current develop branch.

Other

No response
@sainthkh sainthkh added the process: build Related to our internal build process label May 2, 2022
@jennifer-shehane
Copy link
Member

Thanks for letting us know, we'll prioritize fixing this.

@flotwig flotwig self-assigned this May 2, 2022
@flotwig flotwig mentioned this issue May 2, 2022
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels May 2, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels May 2, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 2, 2022

The code for this is done in cypress-io/cypress#21292, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 9, 2022

Released in 9.6.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.6.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flotwig flotwig

Labels
process: build Related to our internal build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix circle-env for contributor PRs cypress-io/cypress
3 participants
@flotwig @jennifer-shehane @sainthkh