Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates based on PR feedback #21137

Merged
merged 46 commits into from Apr 22, 2022
Merged

Conversation

chrisbreiding
Copy link
Contributor

Updates based on feedback on the feature branch.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 19, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 19, 2022



Test summary

38918 0 465 4Flakiness 7


Run details

Project cypress
Status Passed
Commit fde3acf
Started Apr 22, 2022 7:44 PM
Ended Apr 22, 2022 8:01 PM
Duration 16:48 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/multi-domain/commands/multi_domain_actions.spec.ts Flakiness
1 cy.origin actions > #consoleProps > .submit()
e2e/multi-domain/commands/multi_domain_navigation.spec.ts Flakiness
1 cy.origin navigation > .visit() > supports auth options and adding auth to subsequent requests
cypress/proxy-logging_spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
3 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding changed the title add generic to cy.origin type chore: Updates based on PR feedback Apr 19, 2022
@chrisbreiding chrisbreiding marked this pull request as ready for review April 22, 2022 16:20
@chrisbreiding chrisbreiding requested review from a team as code owners April 22, 2022 16:20
@chrisbreiding chrisbreiding requested review from jennifer-shehane, flotwig and ryanthemanuel and removed request for a team April 22, 2022 16:20
@chrisbreiding
Copy link
Contributor Author

@flotwig, @ryanthemanuel, I'm working on preventing requests from being paused when the experimental flag is off, but otherwise I think this PR covers all the feedback we've received so far.

@AtofStryker
Copy link
Contributor

I somehow missed this feedback branch earlier and wound up pushing 885541e to the main feature-multidomain branch 🤦 . If I need to address any other PR feedback, I will be sure to leverage this branch instead and sorry for the mixup!

@jennifer-shehane jennifer-shehane removed their request for review April 22, 2022 17:07
@mjhenkes mjhenkes merged commit 3e6d6bf into feature-multidomain Apr 22, 2022
@mjhenkes mjhenkes deleted the md-pr-feedback branch April 22, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants