Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error experience in run mode and open mode #20124

Closed
brian-mann opened this issue Feb 9, 2022 · 1 comment · Fixed by #20072
Closed

Improve error experience in run mode and open mode #20124

brian-mann opened this issue Feb 9, 2022 · 1 comment · Fixed by #20072
Assignees

Comments

@brian-mann
Copy link
Member

brian-mann commented Feb 9, 2022

What would you like?

  • Many errors are incorrectly constructed when user code is involved, which obfuscates the stack trace
  • Most newer errors have inconsistent and arbitrary styling and formatting
  • Errors propagated in the desktop GUI are rendered incorrectly
  • ANSI styles are not always stripped from the stacks
  • Many stack traces are flat out wrong
  • There are multiple stack traces rendered (from the original error and the internally handled cypress error)
  • Errors are backticked in stdout for use in markdown, instead of being ANSI styled
  • Errors originating from user code in the desktop-gui hide the most important detail (the stack trace) and require "opening" the error details - while the Stack Trace details button repeats the same wrapped error and offers zero benefit

Examples (not exhaustive)

Hidden stacks from user code - with the details of the message only showing in the expanded stack
Screen Shot 2022-02-09 at 12 30 45 PM

Screen Shot 2022-02-09 at 12 30 52 PM

Screen Shot 2022-02-09 at 12 32 49 PM

Screen Shot 2022-02-09 at 12 32 58 PM

Duplicate stacks - one from the constructed error, one from the user error
Screen Shot 2022-02-09 at 12 34 13 PM

ANSI styles not stripped, showing up in stack traces
Screen Shot 2022-02-09 at 12 35 49 PM

Backticks, backticks, backticks formatting
Screen Shot 2022-01-28 at 3 40 44 PM

image

General formatting and readability
Screen Shot 2022-02-09 at 12 53 42 PM

Screen Shot 2022-02-09 at 12 55 03 PM

Screen Shot 2022-02-09 at 12 55 46 PM

Why is this needed?

No response

Other

No response

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 15, 2022

Released in 9.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant