Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gray out the path to system node in cypress run header #20121

Merged
merged 2 commits into from Feb 11, 2022

Conversation

brian-mann
Copy link
Member

@brian-mann brian-mann commented Feb 9, 2022

User facing changelog

  • Gray out the system node path in the terminal run header

How has the user experience changed?

Before
Screen Shot 2022-02-09 at 10 54 39 AM

After
Screen Shot 2022-02-09 at 10 55 57 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)

@brian-mann brian-mann requested a review from a team as a code owner February 9, 2022 17:24
@brian-mann brian-mann requested review from jennifer-shehane and removed request for a team February 9, 2022 17:24
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 9, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 9, 2022



Test summary

19230 7 218 0Flakiness 11


Run details

Project cypress
Status Failed
Commit 4079e2b
Started Feb 10, 2022 5:09 PM
Ended Feb 10, 2022 5:20 PM
Duration 11:38 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: 5x-driver-electron (Linux, Electron )
cypress/integration/e2e/e2e_cookies_spec.js Failed
1 e2e cookies spec > __Host- prefix > can set __Host- cookie
2 e2e cookies spec > __Host- prefix > errors when __Host- cookie and secure:false
3 e2e cookies spec > __Host- prefix > errors when __Host- cookie and path
Run group: 5x-driver-chrome:beta (Linux, Chrome beta )
cypress/integration/e2e/e2e_cookies_spec.js Failed
1 e2e cookies spec > __Host- prefix > can set __Host- cookie
Run group: 5x-driver-chrome (Linux, Chrome )
cypress/integration/e2e/e2e_cookies_spec.js Failed
1 e2e cookies spec > __Host- prefix > can set __Host- cookie
2 e2e cookies spec > __Host- prefix > errors when __Host- cookie and path
3 e2e cookies spec > __Secure- prefix > can set __Secure- cookie

Flakiness

commands/xhr_spec.js Flakiness
1 ... > no status when request isnt forced 404
e2e/e2e_cookies_spec.js Flakiness
1 e2e cookies spec > __Host- prefix > errors when __Host- cookie and secure:false
2 e2e cookies spec > __Secure- prefix > can set __Secure- cookie
3 e2e cookies spec > __Secure- prefix > errors when __Secure- cookie secure:false
4 e2e cookies spec > __Host- prefix > errors when __Host- cookie and secure:false
This comment includes only the first 5 flaky tests. See all 11 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have tests around our colorization of text specifically. This looks like a good change.

@flotwig flotwig changed the title feat: gray out the path to system node in cypress run header feat: gray out the path to system node in cypress run headerx Feb 10, 2022
@flotwig flotwig changed the title feat: gray out the path to system node in cypress run headerx feat: gray out the path to system node in cypress run header Feb 10, 2022
@brian-mann
Copy link
Member Author

I don't know why semantic PR is failing

@brian-mann brian-mann merged commit 4b50f9e into develop Feb 11, 2022
@brian-mann brian-mann deleted the feat/system-node-header branch February 11, 2022 14:55
tgriesser added a commit that referenced this pull request Feb 14, 2022
* develop:
  feat: gray out the path to system node in cypress run header (#20121)
  feat: redesign server errors (#20072)
  test: fix awesome-typescript-loader test and remove test-binary job (#20131)
  fix: Fix issues with stack traces and command log in Chrome 99 (#20049)
  fix: `cy.type(' ')` fires click event on button-like elements. (#20067)
  fix: `change`, `input` events are not fired when the same option is selected again. (#19623)
  build: publish vue3 on latest (#20099)
  chore: release @cypress/webpack-preprocessor-v5.11.1
  chore: release @cypress/webpack-dev-server-v1.8.1
  fix: detect newly added specs in dev-server compilation (#17950)
  chore: Remove pkg/driver //@ts-nocheck part 3 (#19837)
  chore: set up semantic-pull-request GitHub Action (#20091)
  chore: release @cypress/react-v5.12.2
  fix: remove nullish coalescing in js files to support node 12 (#20094)
  docs: update @cypress/webpack-preprocessor links (#19902)
  refactor: use aliases instead of meta (#19566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gray out the path to system node in cypress run header
3 participants