chore(driver): move cy.focused and cy.root into their own files #20054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyrohrbough
requested review from
jennifer-shehane
and removed request for
a team
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||
mjhenkes
approved these changes
Feb 10, 2022
tgriesser
added a commit
that referenced
this pull request
Feb 22, 2022
* develop: (35 commits) fix(deps): update dependency url-parse to v1.5.6 [security] (#20270) chore: fix cache keys to include PLATFORM (#20279) chore: fix server performance flake (#20271) test(system-tests): support docker-based tests against built binary (#20250) chore: fix system-test-firefox screenshots_spec flake (#20268) chore(deps): update dependency fs-extra to v9 🌟 (#19939) fix: Wait for child process to be ready (#19792) fix: treat form-data bodies as binary (#20144) test: replace cypress-test-example-repos coverage + remove bump (#20186) fix(driver): update wrapErr to ignore number and boolean values (#20172) release 9.5.0 [skip ci] chore: Update Chrome (stable) to 98.0.4758.102 (#20192) chore: enable volar.takeOverMode Add span names, merge develop fix: Update `.type(' ')` to not emit clicks when the keyup event has been prevented (#20156) test: remove redundant "other projects" CI jobs (#20133) chore(driver): move cy.focused and cy.root into their own files (#20054) Move sending root event to own script chore: release @cypress/vue-v3.1.1 chore: release @cypress/react-v5.12.3 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
cy.focused()and thecy.root()'s command logic into their own file. This will make finding these command easier since it'll be located with a file named after the command.User facing changelog
n/a
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?