Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Honeycomb system-test reporter #19855

Merged
merged 15 commits into from Jan 27, 2022
Merged

Conversation

BlueWinds
Copy link
Contributor

Draft PR, not ready for review.

User facing changelog

No user-facing changes.

Additional details

Reports system-test timings to honeycomb when run in circleci.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 24, 2022

Thanks for taking the time to open a PR!

@BlueWinds BlueWinds changed the title Honeycomb system-test reporter test: Honeycomb system-test reporter Jan 24, 2022
@cypress
Copy link

cypress bot commented Jan 25, 2022



Test summary

19145 0 218 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 2643d9c
Started Jan 27, 2022 5:08 PM
Ended Jan 27, 2022 5:20 PM
Duration 11:19 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BlueWinds BlueWinds marked this pull request as ready for review January 26, 2022 18:29
@BlueWinds BlueWinds requested a review from a team as a code owner January 26, 2022 18:29
@BlueWinds BlueWinds requested review from jennifer-shehane and removed request for a team January 26, 2022 18:29
@jennifer-shehane jennifer-shehane removed their request for review January 26, 2022 18:46
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
system-tests/lib/performance-reporter.js Show resolved Hide resolved
system-tests/lib/performance-reporter.js Outdated Show resolved Hide resolved
@@ -66,7 +66,7 @@ class StatsdReporter {
version: pkg.version,
})

// honeycombEvent.send()
honeycombEvent.send()
Copy link
Contributor Author

@BlueWinds BlueWinds Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, commented it out for local testing while I messed with things. Thanks for the fix

@tgriesser tgriesser self-requested a review January 26, 2022 23:57
tgriesser
tgriesser previously approved these changes Jan 26, 2022
@BlueWinds BlueWinds merged commit f5cb2b9 into develop Jan 27, 2022
@BlueWinds BlueWinds deleted the issue-19403-performance-tests branch January 27, 2022 17:53
tgriesser added a commit that referenced this pull request Jan 28, 2022
* develop:
  fix: correct reference branch / commitSha in performance-reporter (#19941)
  test: Honeycomb system-test reporter (#19855)
  fix(deps): update dependency engine.io to v5.2.1 [security]
  feat: Retain fileName when working with aliased fixtures and files (#19820)
  Update release-process.md
  Update release-process.md
  Update release-process.md
  Update release-process.md
  Update release-process.md
  Update release-process.md
  Phrasing
  Updating release guide with findings from 9.3.0 release snafu
  add link to the video how to report Cypress bug
tgriesser added a commit that referenced this pull request Jan 31, 2022
* 10.0-release: (25 commits)
  fix(unify): improve dev server config ergonomics (#19957)
  feat: add spec pattern modal (#19801)
  fix: Windows e2e project scaffolding issues (#19938)
  feat: update @cypress/schematic to use proper e2e config for 10.0.0 (#19827)
  fix: correctly migrate projects with custom integration folder (#19929)
  fix: component spec creation with spec pattern (#19862)
  fix: missed committing yarn.lock after merge conflict
  fix: correct reference branch / commitSha in performance-reporter (#19941)
  feat: update navbar UI per Figma (#19926)
  fix: seed examples files when no e2e directory is created (#19768)
  chore: remove windy lightBlue warning
  test: component test updates (#19925)
  feat: Focus browser from select browser screen and on dashboard login (#19842)
  test: Honeycomb system-test reporter (#19855)
  fix(deps): update dependency engine.io to v5.2.1 [security]
  feat: Retain fileName when working with aliased fixtures and files (#19820)
  Update release-process.md
  Update release-process.md
  Update release-process.md
  Update release-process.md
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants